Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build|OSGi] Migrate from Maven-Bundle-Plugin to Bnd-Maven-Plugin #893

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

HannesWell
Copy link
Collaborator

The former uses the latter under the hood, thus the latter is always more recent and more powerful.

@HannesWell HannesWell force-pushed the migrate-to-bnd-maven-plugin branch from 4637111 to c09cb0e Compare January 10, 2024 14:15
@HannesWell HannesWell changed the title [Build] Migrate from Maven-Bundle-Plugin to Bnd-Maven-Plugin [Build|OSGi] Migrate from Maven-Bundle-Plugin to Bnd-Maven-Plugin Jan 10, 2024
@HannesWell
Copy link
Collaborator Author

@axkr the bnd-maven-plugin in the latest version requires Java-17 to run the build.
Would you be fine to build with Java-17 (Symja can still target Java-11) or should I use the version before?

@HannesWell HannesWell force-pushed the migrate-to-bnd-maven-plugin branch 2 times, most recently from d51b02c to 5572f89 Compare January 10, 2024 14:49
@HannesWell HannesWell force-pushed the migrate-to-bnd-maven-plugin branch 2 times, most recently from 70031cf to d0c9d29 Compare January 10, 2024 17:50
@HannesWell
Copy link
Collaborator Author

HannesWell commented Jan 10, 2024

As discussed I have now updated the build to use Maven toolchains to run the Maven build itself with Java-17 but compile with a Java-11 JDK.
Since Java-9 it is actually sufficient to set the release property of the compiler in order to target older releases safely since the JDK reliably checks if a reference standard Java method is available in the targeted version. But when using toolchains we can be absolutely sure (also I'm not aware of a case where the release option did not work as desired).

but still target 11.
The subsequent Maven-plugin update requires Java-17 to run the build
itself.
@HannesWell HannesWell force-pushed the migrate-to-bnd-maven-plugin branch from d0c9d29 to d33b382 Compare January 10, 2024 18:08
The former uses the latter under the hood, thus the latter is always
more recent and more powerful.
The Bnd-Maven-Plugin requires Java-17 to run the Maven build.
@HannesWell HannesWell force-pushed the migrate-to-bnd-maven-plugin branch from d33b382 to cc95372 Compare January 10, 2024 18:17
@HannesWell HannesWell merged commit ae597a1 into axkr:master Jan 10, 2024
2 of 3 checks passed
@HannesWell HannesWell deleted the migrate-to-bnd-maven-plugin branch January 10, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants