Skip to content

Conversation

R4hul04
Copy link
Contributor

@R4hul04 R4hul04 commented Jul 22, 2025

This PR removes a custom field that was added to the core PostgreSQL ViewStmt structure for supporting T-SQL ALTER VIEW operations. Previously, we added a createOrAlter boolean field to the ViewStmt structure to identify T-SQL ALTER VIEW operations. Instead of extending core structures, we'll use the Viewstmt->options list to determine T-SQL ALTER VIEW and CREATE OR ALTER VIEW operations

Corresponding extension PR - babelfish-for-postgresql/babelfish_extensions#3977

PR that introduced createOrAlter field - #545

Issues Resolved

BABEL-5939

Signed off by: Rahul Parande [email protected]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…s list

to distinguish T-SQL ALTER VIEW operations

Signed-off-by: Rahul Parande <[email protected]>
@R4hul04 R4hul04 changed the title Replace custom 'createOrAlter' field in ViewStmt with standard options list to distinguish T-SQL ALTER VIEW operations Remove custom 'createOrAlter' field in ViewStmt Jul 22, 2025
@tanscorpio7
Copy link
Contributor

tanscorpio7 commented Jul 26, 2025

  1. Please add [BABEL] prefix to all engine PR titles
  2. Interlink the extension and engine, i.e. mention them in each other's description.
  3. Add the link to PR that introducued this field.

@R4hul04 R4hul04 changed the title Remove custom 'createOrAlter' field in ViewStmt [BABEL-5939] Remove custom 'createOrAlter' field in ViewStmt Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants