Skip to content

[BABEL-5939] Remove custom 'createOrAlter' field in ViewStmt #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: BABEL_5_X_DEV__PG_17_X
Choose a base branch
from
Open

[BABEL-5939] Remove custom 'createOrAlter' field in ViewStmt #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/backend/parser/gram.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11245,7 +11245,6 @@ ViewStmt: CREATE OptTemp VIEW qualified_name opt_column_list opt_reloptions
n->replace = false;
n->options = $6;
n->withCheckOption = $9;
n->createOrAlter = false;
$$ = (Node *) n;
}
| CREATE OR REPLACE OptTemp VIEW qualified_name opt_column_list opt_reloptions
Expand All @@ -11260,7 +11259,6 @@ ViewStmt: CREATE OptTemp VIEW qualified_name opt_column_list opt_reloptions
n->replace = true;
n->options = $8;
n->withCheckOption = $11;
n->createOrAlter = false;
$$ = (Node *) n;
}
| CREATE OptTemp RECURSIVE VIEW qualified_name '(' columnList ')' opt_reloptions
Expand All @@ -11280,7 +11278,6 @@ ViewStmt: CREATE OptTemp VIEW qualified_name opt_column_list opt_reloptions
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("WITH CHECK OPTION not supported on recursive views"),
parser_errposition(@12)));
n->createOrAlter = false;
$$ = (Node *) n;
}
| CREATE OR REPLACE OptTemp RECURSIVE VIEW qualified_name '(' columnList ')' opt_reloptions
Expand All @@ -11300,7 +11297,6 @@ ViewStmt: CREATE OptTemp VIEW qualified_name opt_column_list opt_reloptions
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("WITH CHECK OPTION not supported on recursive views"),
parser_errposition(@14)));
n->createOrAlter = false;
$$ = (Node *) n;
}
;
Expand Down
3 changes: 0 additions & 3 deletions src/include/nodes/parsenodes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3782,9 +3782,6 @@ typedef struct ViewStmt
bool replace; /* replace an existing view? */
List *options; /* options from WITH clause */
ViewCheckOption withCheckOption; /* WITH CHECK OPTION */
bool createOrAlter; /* is query 'create view' or 'create or alter view' or 'alter view' */
/* flag is set in gram-tsql-rule.y and gram.y */

} ViewStmt;

/* ----------------------
Expand Down