fix: handle backend errors in pool page #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alter-eggo
approved these changes
Aug 30, 2024
garethfuller
requested changes
Aug 30, 2024
Co-authored-by: Gareth Fuller <[email protected]>
Co-authored-by: Gareth Fuller <[email protected]>
garethfuller
reviewed
Sep 4, 2024
There was a problem hiding this comment.
@agualis I'm struggling to get this to work how I wanted with Error boundaries. It works in dev, but in production it blocks you from rendering error messages that are thrown in server components for security reasons, which makes sense.
I need to move on to something else for now, maybe you could take another look. Maybe you were right to start with by just rendering an error message on the RSC.
agualis
added a commit
that referenced
this pull request
Sep 16, 2024
* fix: pool page error when pool id is not found * fix: avoid alert var * fix: capture pool query backend errors in sentry * Update app/(app)/pools/[chain]/[variant]/[id]/layout.tsx Co-authored-by: Gareth Fuller <[email protected]> * Update app/(app)/pools/[chain]/[variant]/[id]/layout.tsx Co-authored-by: Gareth Fuller <[email protected]> * chore: Use error boundaries * chore: Minor updates * chore: Remove * chore: Handle errors better * chore: Update container height * fix: Await header --------- Co-authored-by: Gareth Fuller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix any backend error in a pool query would crash the app and send an error to sentry.
After this fix: