Skip to content

fix: add bounds check for releases array access in dependency updater #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add bounds check for releases array access in dependency updater #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions dependency_updater/dependency_updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,14 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie
}

if dependencies[dependencyType].TagPrefix == "" {
// Guard against empty release list to avoid index out of range
if len(releases) == 0 {
return "", "", VersionUpdateInfo{}, fmt.Errorf(
"no releases found for %s/%s",
dependencies[dependencyType].Owner,
dependencies[dependencyType].Repo,
)
}
version = releases[0]
if *version.TagName != dependencies[dependencyType].Tag {
diffUrl = generateGithubRepoUrl(dependencies, dependencyType) + "/compare/" +
Expand Down Expand Up @@ -359,8 +367,7 @@ func writeToGithubOutput(title string, description string, repoPath string) erro
return fmt.Errorf("failed to write to GITHUB_OUTPUT file: %s", err)
}

delimiter := "EOF"
descToWrite := fmt.Sprintf("%s<<%s\n%s\n%s\n", "DESC", delimiter, description, delimiter)
descToWrite := fmt.Sprintf("%s=%s\n", "DESC", description)
_, err = f.WriteString(descToWrite)
if err != nil {
return fmt.Errorf("failed to write to GITHUB_OUTPUT file: %s", err)
Expand Down