Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off remote cache for local dev, cleanup github actions UI clutter #749

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

jerrymarino
Copy link
Contributor

Configure bazelrc in the preflight_env.sh script

Ensure we enable existing remote cache on github actions

.bazelrc Show resolved Hide resolved
@thiagohmcruz
Copy link
Contributor

thiagohmcruz commented Aug 1, 2023

Added @luispadron and @mattrobmattrob since they know this workflow better than me

Configure bazelrc in the `preflight_env.sh` script

Ensure we enable existing remote cache on github actions
@jszumski
Copy link
Collaborator

jszumski commented Aug 1, 2023

What is the functional change implemented here? Just defaulting the cache off for local dev?

@jszumski jszumski changed the title Streamline CI config settings Turn off remote cache by default Aug 2, 2023
.github/workflows/preflight_env.sh Outdated Show resolved Hide resolved
This line breaks github actions UI and dumps useless output
@jerrymarino jerrymarino changed the title Turn off remote cache by default Turn off remote cache for local dev, cleanup github actions UI clutter Aug 10, 2023
@jerrymarino
Copy link
Contributor Author

jerrymarino commented Aug 10, 2023

For now I've fixed it when running locally. Also - dropping the -s because it breaks looking at CI output

@jerrymarino jerrymarino merged commit b17f64e into master Aug 10, 2023
8 checks passed
@jerrymarino jerrymarino deleted the jmarino/streamline_ci_config branch August 10, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants