Add the repo rule http_jar
#238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft right now as I can't figure out how to add tests for this. |
Wyverald
force-pushed
the
wyv-http-jar
branch
from
4d04476
to
71aa23e
Compare
|
This would unblock #239, which currently fails because using |
|
OK, this should be good to go. The remaining failures are already happening on master too. |
Wyverald
force-pushed
the
wyv-http-jar
branch
from
e45baef
to
14718b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo rule
http_jarcurrently lives in@bazel_tools, which results in an implicit dependency onrules_javabecause it creates a repo with a BUILD file that usesjava_import. So this repo rule really belongs inrules_java.This PR copies it over from
@bazel_tools//tools/build_defs/repo:http.bzlwith minimal edits.