-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy over runfiles library from Bazel #239
Conversation
@hvadehra @meteorcloudy I just realized that we could also move this over and delete it from bazel_tools. What do you think? We could fix bazelbuild/bazel#24150 here. |
The move sounds fine to me. I'll let @hvadehra do the review. |
.../runfiles/src/main/java/com/google/devtools/build/runfiles/AutoBazelRepositoryProcessor.java
Outdated
Show resolved
Hide resolved
I included the fix in bazelbuild/bazel#24161 |
b2b36ed
to
debe9bd
Compare
No longer stacked |
3cc5085
to
2cbac3a
Compare
@hvadehra This is ready for review now, CI is green. |
@hvadehra Friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay.
ff52380
to
77d33a8
Compare
@Wyverald |
The runfiles library can be maintained independently of Bazel releases and `bazel_tools` can refer to it via an alias. Also set flags to build and test with a hermetic JDK 8 to ensure compatibility with that version.
I'm aware of this (decided not to try to fix it since it's too much work). Is it blocking you? |
If you are aware of this it's fine, it just means that rules_java can't use it yet. |
@fmeum This is causing a few issues on import, could you please change the newly added |
@hvadehra Done |
@hvadehra Could you cut a new release so that this can be integrated into bazelbuild/bazel#24219? |
The runfiles library can be maintained independently of Bazel releases and
bazel_tools
can refer to it via an alias.Also set flags to build and test with a hermetic JDK 8 to ensure compatibility with that version.