Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass extra_pip_args to parse_requirements #2254

Closed
wants to merge 1 commit into from

Conversation

swarren12
Copy link

Bug fix for #2239.

The extra_pip_args variable was not being correctly passed to parse_requirements(), causing further calls to ignore anything that was set here.

This was a problem if, for example, the --trusted-host argument was needed to talk to the index set by experimental_index_url.

Copy link

google-cla bot commented Sep 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@swarren12
Copy link
Author

Seems like some of the builds are failing and I'm not sure if I'll have time to fix them on the fork.

Assuming people approve of this change, I'm happy for someone else to apply it outside of this PR.

@swarren12
Copy link
Author

Fixed by #2258 so will close this one.

@swarren12 swarren12 closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant