fix(bzlmod): correctly wire the extra_pip_args #2258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we were just dropping the
extra_pip_args
passed topip.parse
and were just using the args passed through the requirementsfile. Thanks to @swarren12 for pointing this out.
This PR also passes
extra_pip_args
tosdist
whl_library
instancesso that users can build the
sdists
correctly when usingexperimental_index_url
feature.Summary:
extra_pip_args
when building sdists in experimental modeextra_pip_args
from the file and the pip.parse attrFixes #2239
Closes #2254