Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bzlmod): correctly wire the extra_pip_args #2258

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(bzlmod): correctly wire the extra_pip_args #2258

wants to merge 5 commits into from
+58 −6

Commits on Sep 27, 2024

  1. fix(bzlmod): pass extra_pip_args when building sdists in experimental… 

    … mode
    @aignas
    aignas committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5c819b2 View commit details
    Browse the repository at this point in the history

  2. fix(bzlmod): join extra_pip_args from the file and the pip.parse attr

    @aignas
    aignas committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    fe50515 View commit details
    Browse the repository at this point in the history

  3. test: add a test to ensure that the extra args are joined 

    However this is not a test for the code in question as those tests
probably need to wait for bazelbuild#2253 to land to make the test writing easier.
    @aignas
    aignas committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b90dd58 View commit details
    Browse the repository at this point in the history

  4. doc: changelog

    @aignas
    aignas committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    82a232e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. add the line back - the test is not testing the extension code yet

    @aignas
    aignas committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    eb4cb5c View commit details
    Browse the repository at this point in the history