Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

230 transcription UI #247

Merged
merged 10 commits into from
May 19, 2021
Merged

230 transcription UI #247

merged 10 commits into from
May 19, 2021

Conversation

allishultes
Copy link
Contributor

@allishultes allishultes commented May 14, 2021 •
edited
Loading

Is your Pull Request request related to another issue in this repository ?

Fixes #230

Describe what the PR does

  • Adds a duration field to transcript docs at the time they are created
  • Passes duration to the TranscriptRow component in Storybook

State whether the PR is ready for review or whether it needs extra work

Ready

Additional context

Please review with bbc/digital-paper-edit-storybook/pull/100

@allishultes allishultes mentioned this pull request May 14, 2021
Merged
5 tasks
@allishultes allishultes marked this pull request as ready for review May 14, 2021 15:00
@allishultes allishultes linked an issue May 14, 2021 that may be closed by this pull request
Add 'expires in [X] day' information to the Transcripts #234
Closed
aniablaziak
aniablaziak approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@aniablaziak aniablaziak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good ✨

One thing: you might have to pull the latest master before merge, there are a few changes merged into master yesterday that don't show in your branch and could revert these.

sarahrainbow
sarahrainbow approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@sarahrainbow sarahrainbow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@allishultes allishultes merged commit efedd24 into master May 19, 2021
@allishultes allishultes deleted the 230-transcription-ui branch May 27, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniablaziak aniablaziak aniablaziak approved these changes

@sarahrainbow sarahrainbow sarahrainbow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'expires in [X] day' information to the Transcripts Improve transcribing process in UI
3 participants
@allishultes @sarahrainbow @aniablaziak