Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

230 transcripts #100

Merged
merged 23 commits into from
May 19, 2021
Merged

230 transcripts #100

merged 23 commits into from
May 19, 2021

Conversation

allishultes
Copy link
Contributor

@allishultes allishultes commented May 14, 2021

Is your Pull Request request related to another issue in this repository ?

bbc/digital-paper-edit-firebase#230

Describe what the PR does

Updates the TranscriptRow component to match the designs in the issue linked above:

  • Adds green tick icon next to available transcripts (check font awesome for a good match)
  • Restyles the uploading progress bar to match designs
  • Shows the approximate transcribing time
  • Shows a generic error message when there is a failure
  • Shows file deleted message when the transcript has expired

Screenshot 2021-05-14 at 16 46 38

Screenshot 2021-05-14 at 12 06 46

State whether the PR is ready for review or whether it needs extra work

Ready

Additional context

Please review with bbc/digital-paper-edit-firebase#247

The media duration at the bottom of the cards will only appear for new files, as it is a field that gets added to transcript documents when they're created in Firebase.

Out of scope:

As of now, I can't see how we can tell that an item has queued, and so I haven't been able to verify that the icon change next to the progress message will change when this happens.

I branched off a branch to kick this off so apologies for the duplicate commits on this; shout if you'd like me to rebase or do other Git magic.

@allishultes allishultes marked this pull request as ready for review May 14, 2021 14:52
Copy link
Contributor

@aniablaziak aniablaziak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job Alli, it's looking ace ✨

Just left the comment about the date format 🙂

Copy link
Contributor

@tamsingreen tamsingreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good Alli - have a think about the Moment stuff as the storybook modules are really hefty already.
Things to think about when choosing a third party library might be:

  • how recently/often it's updated (and is it still maintained)
  • how popular it is compared with similar ones (Github stars, NPM downloads, etc)
  • the bundle size (you can see this on the NPM page)
  • does it use ES6 modules (in which case webpack can usually dispose of the stuff we don't need when bundling)
  • or is there another library that does just that one thing?

package.dist.json Outdated Show resolved Hide resolved
src/TranscriptRow/index.js Outdated Show resolved Hide resolved
src/TranscriptRow/rows.js Show resolved Hide resolved
src/TranscriptRow/rows.js Show resolved Hide resolved
@allishultes allishultes merged commit 577ca17 into master May 19, 2021
@allishultes allishultes deleted the 230-transcripts branch May 24, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants