Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add Python verison as option in tests #40

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

rflamary
Copy link
Contributor

No description provided.

Copy link
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would simply not modify the version right away.

.github/workflows/test_benchmarks.yml Outdated Show resolved Hide resolved
@rflamary rflamary changed the title [WIP] Add Python verison as option in tests [MRG] Add Python verison as option in tests Jul 16, 2024
@tomMoral tomMoral merged commit 45fc771 into benchopt:main Jul 16, 2024
4 checks passed
@@ -61,7 +66,7 @@ jobs:
miniforge-variant: Mambaforge
use-mamba: true
channels: conda-forge
python-version: 3.9
python-version: ${{ inputs.benchopt_version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups too fast!

this should be python_version. Just fixed in 8a61f57

This shows that we should modify the CI to run against the modify workflow when updating it... :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants