Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add Python verison as option in tests #40

Merged
merged 2 commits into from
Jul 16, 2024
Merged

[MRG] Add Python verison as option in tests #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
078f4a2
add pyvrsion option
rflamary Jul 16, 2024
e391aa7
Update .github/workflows/test_benchmarks.yml
rflamary Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/test_benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ on:
default: git
required: false
type: string
python_version:
description: Python version to use for the tests.
default: "3.9"
required: false
type: string
extra_args:
description: |
Extra arguments to be passed in benchopt test.
Expand Down Expand Up @@ -61,7 +66,7 @@ jobs:
miniforge-variant: Mambaforge
use-mamba: true
channels: conda-forge
python-version: 3.9
python-version: ${{ inputs.benchopt_version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups too fast!

this should be python_version. Just fixed in 8a61f57

This shows that we should modify the CI to run against the modify workflow when updating it... :(

activate-environment: ${{ env.CONDA_ENV }}

- run: conda info
Expand Down
Loading