Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): update cosmos-sdk deps #2172

Closed
wants to merge 7 commits into from

Conversation

abi87
Copy link
Collaborator

@abi87 abi87 commented Nov 22, 2024

Took the following steps:

  • point all replace clauses to a cosmos-sdk dep to a local version of the repo holding main branch
  • run go mod tidy in each module to cleanup deps:
    • cosmossdk.io/x/auth is not a module anymore so dropped references
    • added cosmossdk.io/x/bankX and cosmossdk.io/x/staking deps
  • once all go mod tidy pass with no changes, moved to unlocking compilation:
    • used bls implementation from cometBFT repo
    • dropped kvStoreService struct in favour of runtime.NewKVStoreService(storeKey) method
    • still some compilation errors around db wrapper being referenced somehow but not existing in cosmos-sdk main
  • run go work sync
  • introduce references to local repo for cosmossdk.io/store and cosmossdk.io/store/v2
  • cleaned up ProvideKVStoreService function (now in cosmos-sdk)
  • fixed compilation issues around bls keys
  • AT THIS STAGE THE BINARY COMPILES

TODO:

  • command genesis add-premined-deposit fails due to bls serialization issues

@abi87 abi87 self-assigned this Nov 22, 2024
Copy link
Contributor

coderabbitai bot commented Nov 22, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.42%. Comparing base (cafd14e) to head (e6b1898).
Report is 23 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2172       +/-   ##
===========================================
+ Coverage   26.34%   40.42%   +14.07%     
===========================================
  Files         361        4      -357     
  Lines       16297       47    -16250     
  Branches       12       12               
===========================================
- Hits         4294       19     -4275     
+ Misses      11732       28    -11704     
+ Partials      271        0      -271     

see 357 files with indirect coverage changes

@abi87 abi87 force-pushed the replace-berachain-cosmos-sdk-point-local-repo branch from 06763eb to dfdfec4 Compare November 22, 2024 21:58
@abi87 abi87 force-pushed the replace-berachain-cosmos-sdk-point-local-repo branch 4 times, most recently from 06c093e to 617db4e Compare November 23, 2024 20:56
@abi87 abi87 force-pushed the replace-berachain-cosmos-sdk-point-local-repo branch from 617db4e to 760e690 Compare November 23, 2024 21:11
}

// CoreKVStore is a wrapper of Core/Store kvstore interface
// Remove after https://github.com/cosmos/cosmos-sdk/issues/14714 is closed.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cosmos sdk PR has been merged so all of this can be dropped

@abi87
Copy link
Collaborator Author

abi87 commented Dec 6, 2024

Replaced by #2221

@abi87 abi87 closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant