chore(all): update cosmos-sdk deps #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2221 +/- ##
==========================================
- Coverage 30.83% 30.78% -0.05%
==========================================
Files 333 333
Lines 15250 15273 +23
Branches 20 20
==========================================
Hits 4702 4702
- Misses 10223 10246 +23
Partials 325 325
|
abi87
force-pushed
the
replace-berachain-cosmos-sdk-point-local-repo-2
branch
from
75cb37e to
8036884
Compare
This was referenced Dec 16, 2024
The code created the key by truncating the 96-bytes long uncompressed key to 48 bytes instead of calling the `Compress` method.
| @@ -30,7 +30,7 @@ import ( | |||
|
|
|||
| // LegacySigner is a BLS12-381 signer that uses a bls.PrivKey for signing. | |||
| type LegacySigner struct { | |||
| *bls12381.PrivKey | |||
| bls12381.PrivKey | |||
There was a problem hiding this comment.
Q: is removing the pointer really required ?
Fix invalid BLS key length error
Co-authored-by: aBear <[email protected]>
calbera
reviewed
Dec 19, 2024
| switch i { | ||
| case 0: | ||
| pubkey, err = client.GetPubKey(s.Ctx()) | ||
| s.Require().NoError(err) | ||
| pk, err = bls12381.NewPublicKeyFromBytes(pubkey) |
There was a problem hiding this comment.
nit: can move this logic into the e2e testing client package to simplify here
calbera
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports the awesome work by @alesforz.
1.23.4go.modto point to latest cometBFT and cosmosSDKcosmossdk.io/store/v2/dbwith"github.com/cosmos/cosmos-db"(see Fixgo.moddependency graph #2300 for context)