Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blobs): Validate Index field in BlobSidecar during processing #2289

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

shotes
Copy link
Contributor

@shotes shotes commented Dec 17, 2024

This PR adds validation of Index field in BlobSidecars.

@shotes shotes marked this pull request as draft December 17, 2024 18:27
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.85%. Comparing base (7e5f02d) to head (705a204).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
da/blob/verifier.go 0.00% 5 Missing ⚠️
da/types/sidecar.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
- Coverage   30.87%   30.85%   -0.02%     
==========================================
  Files         333      333              
  Lines       15230    15237       +7     
  Branches       20       20              
==========================================
  Hits         4702     4702              
- Misses      10203    10210       +7     
  Partials      325      325              
Files with missing lines Coverage Δ
da/types/sidecar.go 78.18% <0.00%> (-2.96%) ⬇️
da/blob/verifier.go 0.00% <0.00%> (ø)

@shotes shotes changed the base branch from main to blob-configurable-constants-cleanup December 17, 2024 22:23
Base automatically changed from blob-configurable-constants-cleanup to main December 18, 2024 09:29
@shotes shotes marked this pull request as ready for review December 18, 2024 16:15
@shotes shotes force-pushed the validate-blobsidecar-index branch from 9ce2c90 to add2c6b Compare December 18, 2024 16:20
@abi87 abi87 merged commit 0a2b137 into main Dec 20, 2024
16 checks passed
@abi87 abi87 deleted the validate-blobsidecar-index branch December 20, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants