Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes as recommended by codacy. #101

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

besser82
Copy link
Owner

This is WIP. Do not merge, yet.

@besser82 besser82 force-pushed the besser82/codacy_fixes branch from b8c5305 to c01c717 Compare February 25, 2020 14:06
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #101 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    94.27%   94.34%   +0.06%     
===========================================
  Files           32       32              
  Lines         3688     3765      +77     
===========================================
+ Hits          3477     3552      +75     
- Misses         211      213       +2     
Impacted Files Coverage Δ
lib/crypt-yescrypt.c 82.00% <0.00%> (-2.79%) ⬇️
lib/alg-sha1.c 100.00% <0.00%> (ø) ⬆️
lib/crypt-static.c 100.00% <0.00%> (ø) ⬆️
lib/alg-hmac-sha1.c 100.00% <0.00%> (ø) ⬆️
lib/crypt-des-obsolete.c 100.00% <0.00%> (ø) ⬆️
lib/alg-sha512.c 99.06% <0.00%> (+<0.01%) ⬆️
lib/alg-md5.c 99.28% <0.00%> (+0.01%) ⬆️
lib/alg-md4.c 99.19% <0.00%> (+0.01%) ⬆️
lib/crypt-sunmd5.c 98.34% <0.00%> (+0.01%) ⬆️
lib/alg-gost3411-2012-core.c 98.88% <0.00%> (+0.02%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b3f02...836a732. Read the comment docs.

@besser82 besser82 force-pushed the besser82/codacy_fixes branch from c01c717 to 836a732 Compare February 25, 2020 14:13
@besser82
Copy link
Owner Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

@zackw
Copy link
Collaborator

zackw commented Oct 12, 2020

Some Markdown processors attach semantic significance to whether or not there are blank lines between elements of a bullet list. (For instance, they render to HTML as <ul><li><p>...</p></li><li><p>...</p></li>...</ul> with blank lines and <ul><li>...</li><li>...</li>...</ul> without.) It doesn't especially matter for TODO.md but I'm concerned that Codacy is applying blanket style rules without taking this into account.

Also, a change that touches only TODO.md shouldn't have any effect on code coverage, do you have any idea why that happened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants