v1.13 #672
Merged
v1.13 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by directly storing it from the API which already provides a
three-digit, INSEE-compliant, 0-padded department code.
> %w[9740082W 7200011Z 0340045P].map { |uai| EstablishmentApi.fetch!(uai)["records"][0]["fields"]["code_departement"] }
> ["974", "02B", "034"]
- etab -> establishments ; - don't go through WebMock (that's the EstablishmentApi spec's job) ; - use a "dehydrated" establishment to avoid flaky specs.
The SYGNE API returns the result within a "scolarite" hash which contains the latest schooling for that student by date of creation (says their documentation). Instead of assuming it's the latest open schooling, try and re-match the schooling and only then update whatever can be updated, at the moment only the status code which is "AP" for apprentices.
we cover pretty much the same thing in paiements.feature
Sometimes the APIs stop returning data for a certain INE. This usually means that the student has changed INE (which happens more frequently than we thought), and means we end up with duplicated data that we cannot delete or ignore. Store the result on the student table for now, and we can deal with how to deal with them later.
This means including all the model validation like correct dates and SEPA-ribs, etc.
jbadavis
approved these changes
Apr 4, 2024
JeSuisUnCaillou
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.