Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13 #672

Merged
merged 14 commits into from
Apr 4, 2024
Merged

v1.13 #672

merged 14 commits into from
Apr 4, 2024

Commits on Apr 2, 2024

  1. establishments: fix the department code logic

    ... by directly storing it from the API which already provides a
    three-digit, INSEE-compliant, 0-padded department code.
    
    > %w[9740082W 7200011Z 0340045P].map { |uai| EstablishmentApi.fetch!(uai)["records"][0]["fields"]["code_departement"] }
    > ["974", "02B", "034"]
    freesteph committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d3d2088 View commit details
    Browse the repository at this point in the history
  2. establishments: fix the spec

    - etab -> establishments ;
    - don't go through WebMock (that's the EstablishmentApi spec's job) ;
    - use a "dehydrated" establishment to avoid flaky specs.
    freesteph committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c760841 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6cad12a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4adc080 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. students: try and parse apprentice status

    The SYGNE API returns the result within a "scolarite" hash which
    contains the latest schooling for that student by date of
    creation (says their documentation).
    
    Instead of assuming it's the latest open schooling, try and re-match
    the schooling and only then update whatever can be updated, at the
    moment only the status code which is "AP" for apprentices.
    freesteph committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    83821f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc9d0be View commit details
    Browse the repository at this point in the history
  3. features: remove duplication

    we cover pretty much the same thing in paiements.feature
    freesteph committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c420c69 View commit details
    Browse the repository at this point in the history
  4. api: store when a student is suddenly lost on the API

    Sometimes the APIs stop returning data for a certain INE. This usually
    means that the student has changed INE (which happens more frequently
    than we thought), and means we end up with duplicated data that we
    cannot delete or ignore.
    
    Store the result on the student table for now, and we can deal with
    how to deal with them later.
    freesteph committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9cf9648 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    92f48c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    0eb5bfe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c2d9e1 View commit details
    Browse the repository at this point in the history
  3. payment requests: block if PFMP or RIBs instances are not valid

    This means including all the model validation like correct dates and
    SEPA-ribs, etc.
    freesteph committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    2c5e1fa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cf261a6 View commit details
    Browse the repository at this point in the history
  5. release: 1.13

    freesteph committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    dc94cc6 View commit details
    Browse the repository at this point in the history