generated from betagouv/rails-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.13 #672
Merged
Merged
v1.13 #672
Commits on Apr 2, 2024
-
establishments: fix the department code logic
... by directly storing it from the API which already provides a three-digit, INSEE-compliant, 0-padded department code. > %w[9740082W 7200011Z 0340045P].map { |uai| EstablishmentApi.fetch!(uai)["records"][0]["fields"]["code_departement"] } > ["974", "02B", "034"]
Configuration menu - View commit details
-
Copy full SHA for d3d2088 - Browse repository at this point
Copy the full SHA d3d2088View commit details -
- etab -> establishments ; - don't go through WebMock (that's the EstablishmentApi spec's job) ; - use a "dehydrated" establishment to avoid flaky specs.
Configuration menu - View commit details
-
Copy full SHA for c760841 - Browse repository at this point
Copy the full SHA c760841View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cad12a - Browse repository at this point
Copy the full SHA 6cad12aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4adc080 - Browse repository at this point
Copy the full SHA 4adc080View commit details
Commits on Apr 3, 2024
-
students: try and parse apprentice status
The SYGNE API returns the result within a "scolarite" hash which contains the latest schooling for that student by date of creation (says their documentation). Instead of assuming it's the latest open schooling, try and re-match the schooling and only then update whatever can be updated, at the moment only the status code which is "AP" for apprentices.
Configuration menu - View commit details
-
Copy full SHA for 83821f9 - Browse repository at this point
Copy the full SHA 83821f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc9d0be - Browse repository at this point
Copy the full SHA bc9d0beView commit details -
we cover pretty much the same thing in paiements.feature
Configuration menu - View commit details
-
Copy full SHA for c420c69 - Browse repository at this point
Copy the full SHA c420c69View commit details -
api: store when a student is suddenly lost on the API
Sometimes the APIs stop returning data for a certain INE. This usually means that the student has changed INE (which happens more frequently than we thought), and means we end up with duplicated data that we cannot delete or ignore. Store the result on the student table for now, and we can deal with how to deal with them later.
Configuration menu - View commit details
-
Copy full SHA for 9cf9648 - Browse repository at this point
Copy the full SHA 9cf9648View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92f48c1 - Browse repository at this point
Copy the full SHA 92f48c1View commit details
Commits on Apr 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0eb5bfe - Browse repository at this point
Copy the full SHA 0eb5bfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c2d9e1 - Browse repository at this point
Copy the full SHA 3c2d9e1View commit details -
payment requests: block if PFMP or RIBs instances are not valid
This means including all the model validation like correct dates and SEPA-ribs, etc.
Configuration menu - View commit details
-
Copy full SHA for 2c5e1fa - Browse repository at this point
Copy the full SHA 2c5e1faView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf261a6 - Browse repository at this point
Copy the full SHA cf261a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc94cc6 - Browse repository at this point
Copy the full SHA dc94cc6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.