Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document why MAX_JOINTS and MAX_MORPH_WEIGHTS are set #15974

Open
alice-i-cecile opened this issue Oct 17, 2024 · 0 comments · May be fixed by #16324
Open

Document why MAX_JOINTS and MAX_MORPH_WEIGHTS are set #15974

alice-i-cecile opened this issue Oct 17, 2024 · 0 comments · May be fixed by #16324
Labels
A-Animation Make things move and change over time A-glTF Related to the glTF 3D scene/model format C-Docs An addition or correction to our documentation S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@alice-i-cecile
Copy link
Member

This values are used to allocate buffers. Their maximum sizes depend on the GPU/platform, the current values are the ones guaranteed to work everywhere.
To allow bigger values, you would have to check against the limits of the GPU at runtime, which would mean not using consts anymore.

Originally posted by @mockersf in #15972 (review)
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Animation Make things move and change over time S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! A-glTF Related to the glTF 3D scene/model format labels Oct 17, 2024
@BenjaminBrienen BenjaminBrienen linked a pull request Nov 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-glTF Related to the glTF 3D scene/model format C-Docs An addition or correction to our documentation S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document why MAX_JOINTS and MAX_MORPH_WEIGHTS are set BenjaminBrienen/bevy
1 participant
@alice-i-cecile