Skip to content

Rename type_id method on systems to system_type #19372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alice-i-cecile opened this issue May 26, 2025 · 3 comments
Open

Rename type_id method on systems to system_type #19372

alice-i-cecile opened this issue May 26, 2025 · 3 comments
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@alice-i-cecile
Copy link
Member 

          If we rename the method, I'd vote for `system_type` because not every `System` is a wrapper. It also aligns with `SystemSet::system_type`

Originally posted by @urben1680 in #18931 (comment)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon labels May 26, 2025
@andristarr
Copy link
Contributor

Working on it

@andristarr andristarr mentioned this issue May 26, 2025
Closed
@andristarr
Copy link
Contributor

It should be RFR

@andristarr
Copy link
Contributor

Can we just name it type() and basically it would be basically a prop getter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ecs systems type_id renamed to system_type andristarr/bevy
2 participants
@alice-i-cecile @andristarr