-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Schema changes related to BEP032 #1826
base: bep032
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
particiapants.tsv
for BEP032participants.tsv
for BEP032
src/schema/objects/columns.yaml
Outdated
enum: | ||
- $ref: objects.enums.postnatal.value | ||
- $ref: objects.enums.fetal.value | ||
- $ref: objects.enums.gestational.value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ree-gupta ! I wonder if we better propose this as a PR against current bids version, just keep surgery_date
for the BEP032 but propose age_category
and age_type
.
It also would complement
- Clarify that age Units could be overriden + that type is number OR "89+" string #1791
which I am yet to finish.
Then it would give it a better chance for discussion etc.
Also I guess they should be added as recommended to
https://github.com/bids-standard/bids-specification/blob/master/src/schema/rules/tabular_data/modality_agnostic.yaml#L2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Also, birthdate
is another column suggested by the BEP032.
src/schema/objects/enums.yaml
Outdated
Also known as "embryonic age," this measures the age of a | ||
fetus or embryo from the time of conception. It's typically about two weeks | ||
less than the gestational age. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For humans, but not other species, right? Or is this common across a broad spectrum of species?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure. For now, I removed these changes from here as suggested by Yarik and moved them to #1839 where it reflects the bep032 doc in its current state.
participants.tsv
for BEP032for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@ree-gupta Thanks again for working on this! Could you please "enable" |
Sure thing! Thank you for the suggestion. |
…gin and setup fields
age
Formalize participants' age to clarify the reference point #1634surgery_date
_probes.tsv
_probes.tsv
_electrodes.tsv
_electrodes.tsv
_channels.tsv
_channels.tsv
_scans.tsv
--> not required as already inherited from main BIDS_scans.tsv
--> not required as already inherited from main BIDS_events.tsv
_events.tsv
_coordsystem.json
_ephys.json
(except probe information as decision pending)for e.g.-> for example,@bids-standard/bep032