-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Schema changes related to BEP032 #1826
base: bep032
Are you sure you want to change the base?
Changes from 5 commits
1b7234f
47c2a03
cfc163e
b9894f5
414f272
3833e28
7079c18
11bffa0
ab66a63
b3c2b43
2e7fd70
29704ce
73e600e
e67f946
1622986
749a7c9
329b1e2
8a0df20
8caaaf2
0b75398
9400f4f
3626004
2ff94e0
1a1d3c6
30974f8
f524dfe
686b559
c9e2eb3
c2a251a
c130ad5
8c658b8
fe441bc
f825531
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1405,3 +1405,24 @@ microvascular: | |
display_name: microvascular | ||
description: | | ||
The origin of a tissue: microvascular | ||
postnatal: | ||
value: postnatal | ||
display_name: postnatal | ||
description: | | ||
This is the actual time that has passed since a subject's birth, | ||
also known as “chronological age”. | ||
If age_type is omitted, age is assumed to be this type. | ||
fetal: | ||
value: fetal | ||
display_name: fetal | ||
description: | | ||
Also known as "embryonic age," this measures the age of a | ||
fetus or embryo from the time of conception. It's typically about two weeks | ||
less than the gestational age. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For humans, but not other species, right? Or is this common across a broad spectrum of species? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure. For now, I removed these changes from here as suggested by Yarik and moved them to #1839 where it reflects the bep032 doc in its current state. |
||
gestational: | ||
value: gestational | ||
display_name: gestational | ||
description: | | ||
This measures the duration of pregnancy from the first day of the | ||
mother's last menstrual period to the current date. This should be included | ||
for experiments where some subjects have not been born. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ree-gupta ! I wonder if we better propose this as a PR against current bids version, just keep
surgery_date
for the BEP032 but proposeage_category
andage_type
.It also would complement
which I am yet to finish.
Then it would give it a better chance for discussion etc.
Also I guess they should be added as recommended to
https://github.com/bids-standard/bids-specification/blob/master/src/schema/rules/tabular_data/modality_agnostic.yaml#L2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Also,
birthdate
is another column suggested by the BEP032.