-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] BEP001 - Quantitative MRI #508
Conversation
* Suffix has a wider semantic scope than "modality" * So that it can better represent different types of anatomy imaging applications
* The removed table was an incoherent collection of MRI terms, in which sequence names (e.g. FLASH), weighting labels (e.g. T1w), parametric maps (e.g. T1map) and unspecified MR attributes (e.g. PD) were collapsed under the term "modality". * Format specified by a sequence name does not necessarily ensure interchangeability, given that the same sequence can generate different contrasts. * Descriptions were missing for 8/14 entries. * Existing descriptions were not comprehensive.
* A brief description, expanding on the scope of anatomy imaging using MRI
* Added as a subsection to the Anatomy imaging data section.
* Why a bundle of images may be needed. * Introduce the term `grouped scan collections` * Why suffix is made adaptive to the type of anatomy imaging method.
* Suffix is divided into 3 categories for: * Conventional MRI * Grouped scans * qMRI maps * Add note about legacy suffixes
* For existing datasets
* Function description
* VFA, IRT1, MP2RAGE, MESE, MEGRE, MTR, MTS, MPM, B1DAM
* Reference to the entity table and qMRI appendix * Note regarding the use of constituent images of a grouping suffix for structural data processing.
* Function description
* T1map, T2map, T2starmap, R1map, R2map, R2starmap, PDmap, MTRmap, MTsat, UNIT1, T1rho, MWFmap, PDT2map, B1plusmap
[ENH] Suffix Introduction
[ENH] Suffix entity & Legacy table
[ENH] Suffix type II: Grouping suffix
I think so too, yes. What's worse is that we generally don't specify which "data types" (string, array, object, numeric, ...) to use in the JSON files. On the plus side, the validator checks some of these data types --> but apparently not everything ... or "not everything well enought". Sounds to me like we should open an issue and discuss how to remedy this problem with a small PR. |
@@ -161,6 +396,75 @@ can also be used to make that distinction. At what level of detail to make the | |||
distinction (e.g. just between RARE and FLASH, or between RARE, FLASH, and | |||
FLASHsubsampled) remains at the discretion of the researcher. | |||
|
|||
#### The `echo` entity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not specify any units in this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agahkarakuzu - you are correct the units are in the timing table. perhaps what's needed is a link between the mention in this section and the link to the table. i know this is being discussed in a separate issue, so for this BEP, please feel free to resolve this issue for now.
of the MRI signal is represented in voxel data. The `part-<label>` key/value pair is | ||
associated with the DICOM tag | ||
[0008,9208](https://dicom.innolitics.com/ciods/enhanced-mr-image/enhanced-mr-image/00089208). | ||
Allowed label values for this entity are `phase`, `mag`, `real` and `imag`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should part-complex
be supported too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsalo while we were discussing about adding real
and imag
as supported part
values for complex data, mixed type did not appear to be a common choice among many people. Do you know cases where it can be useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's definitely not common to store complex data. The only thing I'm aware of that uses complex data right off the bat is dwidenoise, but it is supposed to be the first thing used (before any other preprocessing).
Converging to a solution for
|
Icon | Means |
---|---|
👍 | Sounds good, commit the changes |
👀 | Not bad, I have some suggestions to improve |
👎 | Nope, not a good idea at all |
To clarify #530, I only used the term "acquisition" because there isn't an established term for grouped collections yet. It would work in conjunction with #529 (and the above), meaning that entities would essentially be split into "sufficient to distinguish grouped scans" and "insufficient to separate groups of scans". Essentially, if the only thing distinguishing two files is one of these within-acquisition entities (e.g., |
**If the provenance record of the qMRI map generation is available:** | ||
|
||
In this case, qMRI maps SHOULD be stored in the `derivatives` folder, but MAY | ||
be symbolic linked to the corresponding raw data directory to facilitate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tsalo for the pointer, I was following that discussion and planning to bring this up in our next BEP001 meeting. We will soon have another meeting before taking actions to address comments and implement changes I suggested above.
Hi everyone, After long discussions with many people involved, we finally have a roadmap to refactor this PR and split it into manageable bits. I think we settled on several important issues such as not introducing a These decisions call for a major revision to this PR, both contextually and structurally. To make development easier, we decided on closing this PR, then sending smaller (revised) BEP001 PRs starting with the common principle of If maintainers and other people involved in this PR agree (+1s would be a good indicator), I will soon close this PR and start working on a new fork on |
Dear BIDS community,
The field of anatomical MRI has recently seen a bloom of techniques that allow us
to characterize brain tissue in new ways and visualize brain structure that remained
invisible before.
This new set of techniques has become known as quantitative MRI (qMRI),
offering the possibility of quantifying brain tissue in physical units, such as
T1
,T2
andT2*
in seconds. Quantitative MRI provides neuroimaging researcherswith numerous novel applications such as the delineation of specific subcortical nuclei
in the subcortex, parcellation of the visual system based on laminar myeloarchitecture and measuring the myelination of white matter bundles in an absolute scale, just to count a few.
Unfortunately, these data are not easily collected and need computational modeling
to come to full bloom. Of course, BIDS could offer some amazing tools to help
researchers make both qMRI data and software more easily accessible. However,
currently BIDS cannot accommodate qMRI data as it confines the description of
anatomical images to grayscale
T1
- orT2-weighted
images.Thanks to the contributions from dozens of researchers over the course
of 3 years, we are very happy to make this pull request for the BIDS extension
proposal 001 to provide support for a wide range of anatomical MRI applications.
This extension will facilitate:
To make this possible, we propose to extend the concept of
suffix
, in the domainof anatomical (
anat
) data. Specifically, anatomical images can now be describedin one of the following 3
suffix
sub-categories:Conventional MRI suffixes
for traditional MRI contrasts, e.g.,_T1w
and_T2w
Grouping suffixes
to group together multi-contrast images collected for qMRIapplications, e.g.,
_MP2RAGE
and_MPM
Quantitative map suffixes
for the quantitative parametric images such as_T1map
(s),_T2map
(s) and_Chimap
(ppm).Categories (2) and (3) allow data set curators to clearly indicate
which images should be considered together in further (computational) processing,
and which images have interpretable units, respectively.
To further accommodate researchers using qMRI, we also introduced some new metadata
fields that are particularly important when fitting biophysical models to MRI data
and guidelines on which metadata are necessary for some more common qMRI protocols.
Most of these metadata fields should not be controversial, but some of you might
be surprised that we introduced two new fields, called
RepetitionTimePreparation
and
RepetitionTimeExcitation
. These do not replace, but extend the originalRepetitionTime
-field. Please note that the original definition ofRepetitionTime
in the main specification, which reads as follows:
does not generalize to most anatomical MRI protocols. Moreover, in some qMRI
applications, e.g. in the increasingly common MP2RAGE protocol, a (set of) readout
block(s) with multiple excitation pulses is nested in a larger sequence block with,
for example, an inversion pulse. Therefore, we need two definitions of repetition
time: one for the time between preparation blocks, and one for the time between
excitation pulses within each readout block.
Another addition of BEP-001 that might raise some eyebrows is that we moved three
anatomical suffixes (
_T2star
,_FLASH
, and_PD
) to a legacy table. This meansthat using these suffixes is still valid BIDS, but we recommend against using them,
because these suffixes are ambiguous and do not adhere to the structure of the other
anatomical suffixes. Please note that these three suffixes are currently not very
common anyway and that we extensively explain why we recommend against them in the
legacy table.
To conclude, we are very excited to, after years of hard work -not just by us,
but also many others- to share this extension proposal with the larger BIDS community!
We hope that you can give us some constructive feedback. This would allow us to
improve the extension further and finally offer researchers from across the globe
the opportunity to combine the wonders of BIDS and quantitative MRI.
Finally you can find 8 real-life qMRI example data sets organized according to
our BIDS extension proposal at https://osf.io/k4bs5/.
BEP001 GitHub repository: https://github.com/bids-bep001/bids-specification
We would like to note that this PR includes changes that are highly relevant to #424 by @tsalo. The corresponding discussions can be found here.
Kind regards,
Gilles de Hollander (@Gilles86), Agah Karakuzu (@agahkarakuzu), Alberto Lazari (@lazaral), Christophe Phillips (@ChristophePhillips), Kirstie Whitaker (@KirstieJane)