Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove BrowserWarning check for web based validator #1804

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

nellh
Copy link
Member

@nellh nellh commented Sep 14, 2023

The features previously unavailable that required the BrowserWarning are now available and generally compatible across browsers. I think we should remove this check to solve the issue in #1803.

@nellh nellh requested a review from rwblair September 14, 2023 17:34
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.02% ⚠️

Comparison is base (ef044b6) 85.61% compared to head (3869f0d) 83.59%.

❗ Current head 3869f0d differs from pull request most recent head 8cf2a6a. Consider uploading reports for the commit 8cf2a6a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1804      +/-   ##
==========================================
- Coverage   85.61%   83.59%   -2.02%     
==========================================
  Files         131       92      -39     
  Lines        6637     3895    -2742     
  Branches     1536     1272     -264     
==========================================
- Hits         5682     3256    -2426     
+ Misses        847      541     -306     
+ Partials      108       98      -10     

see 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwblair rwblair merged commit ca9ab1d into bids-standard:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants