Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove BrowserWarning check for web based validator #1804

Merged
merged 1 commit into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions bids-validator-web/components/App.jsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import React from 'react'
import bowser from 'bowser'
import Issues from '../components/Issues'
import BrowserWarning from './BrowserWarning'
import Validate from '../components/Validate'
import validate from '../../bids-validator'
import validatorPackageJson from 'bids-validator/package.json' assert { type: 'json' }
Expand Down Expand Up @@ -85,11 +83,6 @@ export default class App extends React.Component {
}

render() {
const browserUnsupported =
!bowser.chrome &&
!bowser.chromium &&
!bowser.firefox &&
typeof window !== 'undefined'
return (
<div id="root">
<nav className="navbar navbar-dark bg-dark fixed-top">
Expand All @@ -105,18 +98,13 @@ export default class App extends React.Component {
</div>
</nav>
<div className="container page-wrapper">
<div className="browser-warning">
{browserUnsupported ? <BrowserWarning /> : null}
</div>
<div className="validator">
{!browserUnsupported ? (
<Validate
loading={this.state.status === 'validating'}
options={this.state.options}
onChange={this.validate}
handleOptionToggle={this.handleOptionToggle}
/>
) : null}
<Validate
loading={this.state.status === 'validating'}
options={this.state.options}
onChange={this.validate}
handleOptionToggle={this.handleOptionToggle}
/>
</div>
{this.state.status === 'validated' ? (
<Issues reset={this.reset} {...this.state} />
Expand Down
23 changes: 0 additions & 23 deletions bids-validator-web/components/BrowserWarning.jsx

This file was deleted.

1 change: 0 additions & 1 deletion bids-validator-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"dependencies": {
"@babel/runtime": "^7.22.10",
"bootstrap": "^5.3.1",
"bowser": "^2.11.0",
"eslint-config-next": "^13.4.19",
"next": "^13.4.7",
"pluralize": "^8.0.0",
Expand Down
2 changes: 0 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.