expose the peer certificates in the connection state #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
peer-certificates
branch
from
e37cc7a to
1006226
Compare
|
@ekr, @bifurcation: Any thoughts on this PR? |
ekr
requested changes
Jan 26, 2018
| serverCertChain := make([]*x509.Certificate, len(state.serverCertificate.CertificateList)) | ||
| for i, certEntry := range state.serverCertificate.CertificateList { | ||
| serverCertChain[i] = certEntry.CertData | ||
| } |
There was a problem hiding this comment.
Does the certificate authenticator do path construction?
There was a problem hiding this comment.
I'm not sure I understand your point. Certificate verification is broken anyway (#161).
conn_test.go
Outdated
| if err != nil { | ||
| panic(err) | ||
| } | ||
| clientKey, clientCert, err = genCerts() |
There was a problem hiding this comment.
You probably don't want this to use the server name.
|
On Fri, Jan 26, 2018 at 3:08 PM, Marten Seemann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In client-state-machine.go
<#162 (comment)>:
> @@ -821,6 +822,10 @@ func (state ClientStateWaitCV) Next(hr handshakeMessageReader) (HandshakeState,
} else {
logf(logTypeHandshake, "[ClientStateWaitCV] WARNING: No verification of server certificate")
}
+ serverCertChain := make([]*x509.Certificate, len(state.serverCertificate.CertificateList))
+ for i, certEntry := range state.serverCertificate.CertificateList {
+ serverCertChain[i] = certEntry.CertData
+ }
I'm not sure I understand your point. Certificate verification is broken
anyway (#161 <#161>).
Yes, but eventually it will be fixed, and so it would be good to have the
semantics be correct when that happens.
…-Ekr
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#162 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABD1oQTSNT8nCUT4Ph3fi5zJz54_FLmrks5tOlrVgaJpZM4RaflB>
.
|
|
Closing in favor of #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConnectionState.PeerCertificatesis now filled with the certificate chain that the peer sent. This works for both the server as well as the client.Note that this PR is unrelated to #161. The certificate chain exposed via
ConnectionState.PeerCertificatesis just what the peer sent.@ekr: This was marked as a TODO for you in the code, so I guess you'll have the most context to review this PR, right?