Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose the peer certificates and the verified chain in the connection state #173

Merged
merged 4 commits into from
Feb 1, 2018

Conversation

marten-seemann
Copy link
Collaborator

@marten-seemann marten-seemann commented Jan 29, 2018

Depends on #172. Fixes #81. Closes #162.

This is a better version of #162, and it's probably the better way to first implement all the verification logic.

The behavior should be analogous to the Go standard library.
I also renamed the Conn.State() to Conn.ConnectionState(), to make mint more consistent with the tls.Conn from the standard library.

Copy link
Owner

@bifurcation bifurcation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not crazy about pulling more X.509 logic in here, but it doesn't look like a huge footprint, so I'll allow it.

@bifurcation bifurcation merged commit a009051 into bifurcation:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants