implement the VerifyPeerCertificate mint.Config option #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #170. Replaces #163.
This PR replaces the
Config.AuthCertificate
with aConfig.VerifyPeerCertificate
. The purpose of both methods is similar (althoughAuthCertificate
never actually worked).VerifyPeerCertificate
is supposed to work exactly like thetls.Config.VerifyPeerCertificate
in the standard library.Note that currently for the server, the
verifiedChains
argument forVerifyPeerCertificate
is always nil. This is consistent with the way we implement client auth (by just requiring the client so send any certificate), which is one of the ways the Go standard library allows client certificate verification. I created #171 to track this, and I'll be happy to contribute some code to resolve this issue in the future.The code was taken from the Go standard library: