Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove route group from account pages #1724

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

chanceaclark
Copy link
Contributor

What/Why?

Removes the route group from the accounts tab.

Testing

Screenshot 2024-12-09 at 17 31 59

@chanceaclark chanceaclark requested a review from a team as a code owner December 9, 2024 22:32
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:39pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:39pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Dec 9, 2024 10:39pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:39pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:39pm

Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: eee5595

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chanceaclark chanceaclark added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit c8b1995 Dec 9, 2024
13 of 14 checks passed
@chanceaclark chanceaclark deleted the refactor/accounts branch December 9, 2024 22:43
Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-eogbrawo1-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 78
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 94
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants