Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove route group from account pages #1724

Merged
merged 1 commit into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ import {
import { Message } from '~/components/ui/message';
import { useRouter } from '~/i18n/routing';

import { useAccountStatusContext } from '../../../account/(tabs)/_components/account-status-provider';
import { SubmitMessagesList } from '../../../account/(tabs)/_components/submit-messages-list';
import { useAccountStatusContext } from '../../../account/_components/account-status-provider';
import { SubmitMessagesList } from '../../../account/_components/submit-messages-list';
import { changePassword } from '../_actions/change-password';

interface Props {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ import {
} from '~/components/ui/form';
import { Message } from '~/components/ui/message';

import { useAccountStatusContext } from '../../../account/(tabs)/_components/account-status-provider';
import { SubmitMessagesList } from '../../../account/(tabs)/_components/submit-messages-list';
import { useAccountStatusContext } from '../../../account/_components/account-status-provider';
import { SubmitMessagesList } from '../../../account/_components/submit-messages-list';
import { login } from '../_actions/login';

const SubmitButton = () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import ReCaptcha from 'react-google-recaptcha';
import {
AccountState as FormStatus,
useAccountStatusContext,
} from '~/app/[locale]/(default)/account/(tabs)/_components/account-status-provider';
import { SubmitMessagesList } from '~/app/[locale]/(default)/account/(tabs)/_components/submit-messages-list';
} from '~/app/[locale]/(default)/account/_components/account-status-provider';
import { SubmitMessagesList } from '~/app/[locale]/(default)/account/_components/submit-messages-list';
import { type FragmentOf } from '~/client/graphql';
import { Button } from '~/components/ui/button';
import {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import ReCaptcha from 'react-google-recaptcha';
import {
AccountState as FormStatus,
useAccountStatusContext,
} from '~/app/[locale]/(default)/account/(tabs)/_components/account-status-provider';
} from '~/app/[locale]/(default)/account/_components/account-status-provider';
import { ExistingResultType } from '~/client/util';
import {
Checkboxes,
Expand Down Expand Up @@ -38,7 +38,7 @@ import { Button } from '~/components/ui/button';
import { Field, Form, FormSubmit } from '~/components/ui/form';
import { Message } from '~/components/ui/message';

import { SubmitMessagesList } from '../../../account/(tabs)/_components/submit-messages-list';
import { SubmitMessagesList } from '../../../account/_components/submit-messages-list';
import { login } from '../_actions/login';
import { registerCustomer } from '../_actions/register-customer';
import { getRegisterCustomerQuery } from '../page-data';
Expand Down
21 changes: 0 additions & 21 deletions core/app/[locale]/(default)/account/(tabs)/layout.tsx

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import { createContext, ReactNode, useContext, useEffect, useState } from 'react

import { usePathname } from '~/i18n/routing';

// import { State as AccountState } from '../settings/change-password/_actions/change-password';

export interface AccountState {
status: 'idle' | 'error' | 'success';
messages: string[];
Expand Down
21 changes: 17 additions & 4 deletions core/app/[locale]/(default)/account/layout.tsx
Original file line number Diff line number Diff line change
@@ -1,16 +1,29 @@
import { getLocale } from 'next-intl/server';
import { setRequestLocale } from 'next-intl/server';
import { PropsWithChildren } from 'react';

import { auth } from '~/auth';
import { redirect } from '~/i18n/routing';

export default async function AccountLayout({ children }: PropsWithChildren) {
const locale = await getLocale();
import { TabNavigation } from './_components/tab-navigation';

interface Props extends PropsWithChildren {
params: Promise<{ locale: string }>;
}

export default async function AccountLayout({ children, params }: Props) {
const { locale } = await params;
const session = await auth();

setRequestLocale(locale);

if (!session) {
redirect({ href: '/login', locale });
}

return children;
return (
<>
<TabNavigation />
{children}
</>
);
}
2 changes: 1 addition & 1 deletion core/app/[locale]/(default)/account/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ReactNode } from 'react';

import { Link } from '~/components/link';

import { AccountNotification } from './(tabs)/_components/account-notification';
import { AccountNotification } from './_components/account-notification';

interface AccountItem {
children: ReactNode;
Expand Down
2 changes: 1 addition & 1 deletion core/app/providers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { PropsWithChildren } from 'react';
import { CartProvider } from '~/components/header/cart-provider';
import { CompareDrawerProvider } from '~/components/ui/compare-drawer';

import { AccountStatusProvider } from './[locale]/(default)/account/(tabs)/_components/account-status-provider';
import { AccountStatusProvider } from './[locale]/(default)/account/_components/account-status-provider';

export function Providers({ children }: PropsWithChildren) {
return (
Expand Down
Loading