Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owtestandscore: Add cancelled tasks to dispose queue #4615

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

ales-erjavec
Copy link
Contributor

Issue

Annother stab at gh-4553

Description of changes
  • Add cancelled tasks to dispose queue until final finished signal.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #4615 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4615      +/-   ##
==========================================
- Coverage   83.63%   83.62%   -0.01%     
==========================================
  Files         281      276       -5     
  Lines       56226    55446     -780     
==========================================
- Hits        47022    46366     -656     
+ Misses       9204     9080     -124     

@ales-erjavec ales-erjavec changed the title [FIX] owtestandscore: Add cancelled tasks to dispose queue [NOMERGE][FIX] owtestandscore: Add cancelled tasks to dispose queue Apr 3, 2020
@ales-erjavec ales-erjavec force-pushed the fixes/test-learners-segfault branch from 2e23f77 to 50c4b3d Compare April 3, 2020 11:16
@ales-erjavec ales-erjavec changed the title [NOMERGE][FIX] owtestandscore: Add cancelled tasks to dispose queue [FIX] owtestandscore: Add cancelled tasks to dispose queue Apr 3, 2020
@janezd janezd merged commit 84b0a9c into biolab:master Apr 3, 2020
@markotoplak
Copy link
Member

Seem to work - I can not crash it anymore. Does this mean we need to add something like this to other widgets that use threads?

@ales-erjavec
Copy link
Contributor Author

I don't know.

@ales-erjavec ales-erjavec deleted the fixes/test-learners-segfault branch August 5, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants