[FIX] Data Table: Fix freeze with large selections #5164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5164 +/- ##
==========================================
+ Coverage 84.79% 84.82% +0.02%
==========================================
Files 286 288 +2
Lines 60189 60349 +160
==========================================
+ Hits 51036 51189 +153
- Misses 9153 9160 +7 |
ales-erjavec
force-pushed
the
header-view-paint-section
branch
2 times, most recently
from
e703c52
to
871a5e1
Compare
Reimplement QHeaderView.paintSection to avoid expensive calls to QItemSelectionModel.isRowSelected.
ales-erjavec
force-pushed
the
header-view-paint-section
branch
from
871a5e1
to
74300a1
Compare
ales-erjavec
changed the title
3 tasks
ales-erjavec
force-pushed
the
header-view-paint-section
branch
from
74300a1
to
a06d044
Compare
Extracted from owtable, slightly generalized.
ales-erjavec
force-pushed
the
header-view-paint-section
branch
from
a06d044
to
82fbbe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-5162
Description of changes
Add a HeaderView class reimplementing QHeaderView.paintSection to avoid expensive calls to
QItemSelectionModel.isRowSelected, which traversed the whole model row/column when all items are selected.
Includes