Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support legacy import #22

Merged
merged 15 commits into from
Sep 16, 2023
Merged

Support legacy import #22

merged 15 commits into from
Sep 16, 2023

Conversation

vedran-kasalica
Copy link
Member

@vedran-kasalica vedran-kasalica commented Sep 12, 2023

The feature that allows the use of legacy metadata files (tsdb). This will be important when importing PPP data from Snellius.

In addition, the formatting of the notebook was improved (lines were not fully visible in the online browser, see Issue 15).

@kretep
Copy link
Member

kretep commented Sep 13, 2023

Could you clean up the exceptions in the processing_example.ipynb output?

@vedran-kasalica
Copy link
Member Author

processing_example

Sure, I will fix that.

@vedran-kasalica vedran-kasalica linked an issue Sep 14, 2023 that may be closed by this pull request
@vedran-kasalica
Copy link
Member Author

@kretep I fixed the notebook outputs, however, due to circular import issues, I had to refactor the code. I did not change the content of the methods, I just re-organised them. The main change is that I split io module, which was quite large, not clear and was causing the mentioned issue into:

  • file_utils,
  • write_binary,
  • read_binary,
  • write_tsdf,
  • read_tsdf

We ended up now with many modules so we might want to group them into packages, or maybe merge some, but I could not find a more elegant alternative to solve the circular imports straight away.

Another reason for the circular imports issue was the repeated import of TSDFmetadata class, often used just for typing. I started using forward reference to mitigate that in the future.

vedran-kasalica and others added 2 commits September 15, 2023 12:17
Not really relevant for users and not exported atm
@kretep kretep merged commit d90c736 into main Sep 16, 2023
1 check passed
@kretep kretep deleted the support_legacy_import branch September 16, 2023 14:41
@vedran-kasalica vedran-kasalica linked an issue Sep 16, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "legacy" TSDF format Unable to read complete cells in Notebook
2 participants