-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support legacy import #22
Conversation
Could you clean up the exceptions in the processing_example.ipynb output? |
Sure, I will fix that. |
@kretep I fixed the notebook outputs, however, due to circular import issues, I had to refactor the code. I did not change the content of the methods, I just re-organised them. The main change is that I split io module, which was quite large, not clear and was causing the mentioned issue into:
We ended up now with many modules so we might want to group them into packages, or maybe merge some, but I could not find a more elegant alternative to solve the circular imports straight away. Another reason for the circular imports issue was the repeated import of TSDFmetadata class, often used just for typing. I started using forward reference to mitigate that in the future. |
Not really relevant for users and not exported atm
The feature that allows the use of legacy metadata files (tsdb). This will be important when importing PPP data from Snellius.
In addition, the formatting of the notebook was improved (lines were not fully visible in the online browser, see Issue 15).