feat(lint/noStaticElementInteractions): add rule #2981

ryo-ebata · 2024-05-25T16:23:45Z

Summary

Enforce that non-interactive, visible elements (such as <div>) that have click handlers use the role attribute.

Implements #527

Test Plan

Added snaps for valid/invalid cases.

Basically, it conforms to the test cases of eslint-plugin-jsx-a11y/no-static-element-interactions, and test cases that cannot be handled by the resources within Biome are handled individually.

ref:
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/no-static-element-interactions-test.js

codspeed-hq · 2024-05-25T17:01:51Z

CodSpeed Performance Report

Merging #2981 will improve performances by 6.22%

_{Comparing ryo-ebata:ryo-ebata/no-static-element-interactions (6c17137) with main (1218c3a)}

Summary

⚡ 1 improvements
✅ 107 untouched benchmarks

Benchmarks breakdown

	Benchmark	`main`	`ryo-ebata:ryo-ebata/no-static-element-interactions`	Change
⚡	`dojo_11880045762646467684.js[cached]`	8.5 ms	8 ms	+6.22%

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs

ryo-ebata · 2024-06-02T09:56:57Z

@unvalley

As this comment states, the following two methods were created to bridge the gap between eslint-plugin-jsx-a11y and Biome

is_valid_element
is_invalid_element

However, I thought it was necessary to optimize the Biome definition based on the official documentation, rather than discussing the two options of which way to go.

Is this an issue that should be addressed in this PR?
If necessary, we will address it in this PR, but I think there is an option to address it in another Issue, PR due to the number of elements.

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs

unvalley · 2024-06-03T17:26:38Z

@ryo-ebata

Is this an issue that should be addressed in this PR?
If necessary, we will address it in this PR, but I think there is an option to address it in another Issue, PR due to the number of elements.

Let's address that in another PR.

unvalley · 2024-06-03T18:41:28Z

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs

+        m.insert("clipboard", vec!["onCopy", "onCut", "onPaste"]);
+        m.insert("composition", vec!["onCompositionEnd", "onCompositionStart", "onCompositionUpdate"]);
+        m.insert("keyboard", vec!["onKeyDown", "onKeyPress", "onKeyUp"]);
+        m.insert("focus", vec!["onFocus", "onBlur"]);
+        m.insert("form", vec!["onChange", "onInput", "onSubmit"]);
+        m.insert("mouse", vec![
+            "onClick", "onContextMenu", "onDblClick", "onDoubleClick", "onDrag", "onDragEnd",
+            "onDragEnter", "onDragExit", "onDragLeave", "onDragOver", "onDragStart", "onDrop",
+            "onMouseDown", "onMouseEnter", "onMouseLeave", "onMouseMove", "onMouseOut",
+            "onMouseOver", "onMouseUp"
+        ]);
+        m.insert("selection", vec!["onSelect"]);
+        m.insert("touch", vec!["onTouchCancel", "onTouchEnd", "onTouchMove", "onTouchStart"]);
+        m.insert("ui", vec!["onScroll"]);
+        m.insert("wheel", vec!["onWheel"]);
+        m.insert("media", vec![
+            "onAbort", "onCanPlay", "onCanPlayThrough", "onDurationChange", "onEmptied",
+            "onEncrypted", "onEnded", "onError", "onLoadedData", "onLoadedMetadata", "onLoadStart",
+            "onPause", "onPlay", "onPlaying", "onProgress", "onRateChange", "onSeeked", "onSeeking",
+            "onStalled", "onSuspend", "onTimeUpdate", "onVolumeChange", "onWaiting"
+        ]);
+        m.insert("image", vec!["onLoad", "onError"]);
+        m.insert("animation", vec!["onAnimationStart", "onAnimationEnd", "onAnimationIteration"]);
+        m.insert("transition", vec!["onTransitionEnd"]);


Do we need elements (and handlers) other than in CATEGORIES_TO_CHECK?
We only use focus, keyboard and mouse.

@unvalley
In ESlint, interactions are managed in independent files named eventHandlersByType.
ref: https://github.com/jsx-eslint/jsx-ast-utils/blob/main/src/eventHandlers.js

Among them, ESlint uses focus, keyboard and mouse by default.
ref: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/974275353598e9407c76bd4a50c331a953755cee/src/rules/no-static-element-interactions.js#L33-L37

In other words, the EVENT_TO_HANDLERS created in this PR was originally intended to be used for other rules, etc., but since it is currently unclear where to place them, they are implemented this way.

Thanks. So, I guess it means we don't have any other rules that need this CATEGORIES_TO_CHECK yet.

Alright, we can locate the hashmap here, but I suggest commenting out elements that aren't used here. It may be a waste of overhead. Insertion for focus, keyboard, and mouse is enough.

@unvalley
I see, I understand!
I'll fix this.

Sorry to barge in during this review. I think this code would benefit from a refactor. I don't think it's a good custom to try to replicate JS code in Rust. For example, this code, while it's created once via lazy_static, still creates a bunch of vectors that are created at runtime (heap).

Instead, why not create simple arrays?

Also, I think we should explain what this code is. It's copied from another source, which is completely fine, but there's no comment that explains what are the keys and what are the values, how they are used and what they are meant to be.

For example composition -> [...]. What's composition? Where is it coming from? Is it an HTML element? Is it a role? Remember that in Biome, we want to aim for good standards, DX-wise and coding-wise.

@unvalley
fixed in this a9aa880

@unvalley
Sorry, I didn't address to additional comments, please leave them as they are.

@ematipico @unvalley
Thank you for pointing this out.
As you said, it was causing overhead, so we defined it as a fixed-length array.

Also modified the comment to describe what is stored in this array and added the URL to the MDN reference describing each event handler

fixed in this commit b330131

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs

ryo-ebata · 2024-06-11T14:45:03Z

@unvalley
Sorry for the delay in correcting the code in response to your comment...
Please check back as I have responded to your comments and corrected the points you raised!

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs

…eractions.rs

…added explanatory comments for better clarity and performance.

…attributes function

ematipico

Awesome! Just needs to remove the commented code, then we can merge it :)

ematipico · 2024-07-04T12:28:55Z

crates/biome_js_analyze/src/services/aria.rs

+                            .text()
+                            .split(' ')


You can use this instead: https://doc.rust-lang.org/std/primitive.str.html#method.split_whitespace

@ematipico
Thanks your advice, I have incorporated the changes you suggested!
2dcbc5e

ematipico · 2024-07-04T12:29:51Z

crates/biome_js_analyze/tests/specs/nursery/noStaticElementInteractions/invalid.jsx

+	{/* <summary> is inherently an interactive element, but in eslint-plugin-jsx-a11y, 
+	    it was made non-interactive due to the influence of an external library. */}
+	{/* ref: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/0be7ea95f560c6afc6817d381054d914ebd0b2ca/src/util/isInteractiveElement.js#L86-L89 */}
+	{/* <summary onClick={() => {}} /> */}
+
+	{/* This element is rejected by HTML Standard */}
+	{/* ref: https://lists.w3.org/Archives/Public/public-whatwg-archive/2012Aug/0298.html */}
+	{/* <content onClick={() => {}} /> */}
+
+	{/* This element is rejected by HTML Standard */}
+	{/* ref: https://html.spec.whatwg.org/multipage/obsolete.html */}
+	{/* <acronym onClick={() => {}} /> */}
+	{/* <applet onClick={() => {}} /> */}
+	{/* <frame onClick={() => { }} /> */}
+	{/* <frameset onClick={() => { }} /> */}
+	{/* <center onClick={() => {}} /> */}
+	{/* <font onClick={() => {}} /> */}	
+	{/* <big onClick={() => {}} /> */}
+	{/* <blink onClick={() => {}} /> */}
+	{/* <rtc onClick={() => {}} /> */}
+	{/* <xmp onClick={() => {}} /> */}
+	{/* <strike onClick={() => {}} /> */}
+	{/* <param onClick={() => {}} /> */}
+	{/* <keygen onClick={() => {}} /> */}
+	{/* <noembed onClick={() => {}} /> */}
+	{/* <spacer onClick={() => {}} /> */}
+	{/* <tt onClick={() => {}} /> */}


Are these commented on purpose? If so, we should add a comment saying why, if not, we should remove them or uncomment them.

@ematipico
I removed those.
7851727

ematipico · 2024-07-04T12:30:31Z

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs

+    // (
+    //     // ref: https://developer.mozilla.org/en-US/docs/Web/API/ClipboardEvent
+    //     "clipboard",
+    //     &[
+    //         // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/copy_event
+    //         "onCopy",
+    //         //ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/cut_event
+    //         "onCut",
+    //         // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/paste_event
+    //         "onPaste",
+    //     ],
+    // ),
+    // (
+    //     // ref: https://developer.mozilla.org/en-US/docs/Web/API/CompositionEvent
+    //     "composition",
+    //     &[
+    //         // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/compositionstart_event
+    //         "onCompositionStart",
+    //         // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/compositionend_event
+    //         "onCompositionEnd",
+    //         // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/compositionupdate_event
+    //         "onCompositionUpdate",
+    //     ],
+    // ),


@ematipico
I addressed this commit!
7851727

ematipico · 2024-07-04T12:30:38Z

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs

+    // (
+    //     "form",
+    //     &[
+    //         /// ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event
+    //         "onChange",
+    //         // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/input_event
+    //         "onInput",
+    //         // https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/submit_event
+    //         "onSubmit",
+    //     ],
+    // ),


@ematipico
I addressed this commit!
7851727

ryo-ebata · 2024-07-04T14:47:40Z

@ematipico @unvalley
Thank you very much for your very extensive review!
I am personally interested in web a11y and would like you to let us continue to develop Biome's a11y rules in the future, may I?

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs

…eractions.rs

unvalley · 2024-07-04T15:34:46Z

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs

+const EVENT_TO_HANDLERS: &[(&str, &[&str])] = &[
+    (
+        // ref https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent
+        "keyboard",
+        &[
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/keydown_event
+            "onKeyDown",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/keyup_event
+            "onKeyUp",
+            //ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/keypress_event
+            "onKeyPress",
+        ],
+    ),
+    (
+        // ref: https://developer.mozilla.org/en-US/docs/Web/API/FocusEvent
+        "focus",
+        &[
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/focus_event
+            "onFocus",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/blur_event
+            "onBlur",
+        ],
+    ),
+    (
+        // ref: https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent
+        "mouse",
+        &[
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/click_event
+            "onClick",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/contextmenu_event
+            "onContextMenu",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/dblclick_event
+            "onDblClick",
+            "onDoubleClick",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/drag_event
+            "onDrag",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dragend_event
+            "onDragEnd",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dragenter_event
+            "onDragEnter",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dragleave_event
+            "onDragLeave",
+            "onDragExit",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dragover_event
+            "onDragOver",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dragstart_event
+            "onDragStart",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/drop_event
+            "onDrop",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/mousedown_event
+            "onMouseDown",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseenter_event
+            "onMouseEnter",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseleave_event
+            "onMouseLeave",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/mousemove_event
+            "onMouseMove",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseout_event
+            "onMouseOut",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseover_event
+            "onMouseOver",
+            // ref: https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseup_event
+            "onMouseUp",
+        ],
+    ),
+];


nits: i think we don't need the ref comments, because they are obvious and redundant.

@unvalley
thank you,
i fixed in this commit!
d09548f

unvalley · 2024-07-04T15:39:26Z

I am personally interested in web a11y and would like you to let us continue to develop Biome's a11y rules in the future, may I?

Of course, helps are always welcome 😄

unvalley · 2024-07-04T15:40:00Z

@ryo-ebata could you apply codegen to pass the CI?

unvalley · 2024-07-04T15:42:55Z

crates/biome_aria/src/roles.rs

+        let role_name = if let Some(role) = attributes.get("role") {
+            if let Some(r) = role.first() {
+                self.get_role(r)
+            } else {
+                None
+            }
+        } else {
+            self.get_implicit_role(element_name, attributes)
+        };
+
+        if let Some(role) = role_name {
+            match role.type_name() {
+                "biome_aria::roles::PresentationRole" | "biome_aria::roles::GenericRole" => {
+                    return false
+                }
+                _ => return true,
+            }
+        }
+
+        false


This can be more simple (if this works)

Suggested change

let role_name = if let Some(role) = attributes.get("role") {

if let Some(r) = role.first() {

self.get_role(r)

} else {

None

}

} else {

self.get_implicit_role(element_name, attributes)

};

if let Some(role) = role_name {

match role.type_name() {

"biome_aria::roles::PresentationRole" | "biome_aria::roles::GenericRole" => {

return false

}

_ => return true,

}

}

false

let role_name = attributes

.get("role")

.and_then(|role| role.first())

.map(|r| self.get_role(r))

.or_else(|| self.get_implicit_role(element_name, attributes));

match role_name.map(|role| role.type_name()) {

Some("biome_aria::roles::PresentationRole" | "biome_aria::roles::GenericRole") => false,

Some(_) => true,

None => false,

}

@unvalley
thanks,
a part of your suggestion code do not work, so i fixed!

7063f9b

unvalley

I left some suggestions but they are nits or for refactor. Thank you!

ryo-ebata · 2024-07-07T06:58:37Z

@unvalley
Thank you for your suggestion!
I have corrected your point and run the just gen-lint and just gen-bindings commands.

Also, I have an existing nursery rule that fails the snapshot test with my changes, so I'm going to address that with another PR.

github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-CLI Area: CLI labels May 25, 2024

ematipico assigned togami2864 May 27, 2024

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed May 29, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed Jun 3, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed Jun 3, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley reviewed Jun 3, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley self-assigned this Jun 7, 2024

ematipico requested review from unvalley and togami2864 June 12, 2024 10:49

unvalley reviewed Jun 12, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

unvalley and others added 9 commits July 4, 2024 13:23

Update crates/biome_js_analyze/src/lint/nursery/no_static_element_int…

981aa46

…eractions.rs

fix: Commented out unnecessary overhead.

90d4bc9

refactor: Improved event handler mappings by using simple arrays and …

f68bd87

…added explanatory comments for better clarity and performance.

refactor: Use constant for SECTION_ARIA_ATTRIBUTES to improve efficiency

d0177c2

refactor: use text_trimmed() for dynamic attribute values in extract_…

d31f8f1

…attributes function

feat: add is_hidden_from_screen_reader()

182eae0

feat: add is_not_static_element method

8f2039c

refactor: run just l

02c17a9

rebase

6394998

ematipico force-pushed the ryo-ebata/no-static-element-interactions branch from 8b225b2 to 6394998 Compare July 4, 2024 12:26

ematipico approved these changes Jul 4, 2024

View reviewed changes

ryo-ebata added 4 commits July 4, 2024 23:28

refactor: delete commented out code

7851727

refactor: new snap

e530ffc

refactor: use split_whitespace method

2dcbc5e

refactor: Corrected description

cabbf1c

unvalley reviewed Jul 4, 2024

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_static_element_interactions.rs Outdated Show resolved Hide resolved

Update crates/biome_js_analyze/src/lint/nursery/no_static_element_int…

4b79dcd

…eractions.rs

unvalley reviewed Jul 4, 2024

View reviewed changes

unvalley approved these changes Jul 4, 2024

View reviewed changes

unvalley and others added 4 commits July 6, 2024 03:17

Merge branch 'main' into ryo-ebata/no-static-element-interactions

6c17137

refactor: delete redundant ref comments

d09548f

refactor: Change to even simpler code that works correctly

7063f9b

chore: apply codegen

d559479

ryo-ebata requested review from unvalley and ematipico July 7, 2024 06:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lint/noStaticElementInteractions): add rule #2981

feat(lint/noStaticElementInteractions): add rule #2981

ryo-ebata commented May 25, 2024 •

edited by unvalley

Loading

codspeed-hq bot commented May 25, 2024 •

edited

Loading

ryo-ebata commented Jun 2, 2024 •

edited

Loading

unvalley commented Jun 3, 2024 •

edited

Loading

unvalley Jun 3, 2024

ryo-ebata Jun 11, 2024

unvalley Jun 12, 2024

ryo-ebata Jun 12, 2024

ematipico Jun 13, 2024 •

edited

Loading

ryo-ebata Jun 15, 2024

ryo-ebata Jun 15, 2024 •

edited

Loading

ryo-ebata Jun 15, 2024 •

edited

Loading

ryo-ebata commented Jun 11, 2024

ematipico left a comment

ematipico Jul 4, 2024

ryo-ebata Jul 4, 2024

ematipico Jul 4, 2024

ryo-ebata Jul 4, 2024

ematipico Jul 4, 2024

ryo-ebata Jul 4, 2024

ematipico Jul 4, 2024

ryo-ebata Jul 4, 2024

ryo-ebata commented Jul 4, 2024

unvalley Jul 4, 2024 •

edited

Loading

ryo-ebata Jul 7, 2024

unvalley commented Jul 4, 2024 •

edited

Loading

unvalley commented Jul 4, 2024 •

edited

Loading

unvalley Jul 4, 2024

ryo-ebata Jul 7, 2024

unvalley left a comment

ryo-ebata commented Jul 7, 2024 •

edited

Loading

feat(lint/noStaticElementInteractions): add rule #2981

Are you sure you want to change the base?

feat(lint/noStaticElementInteractions): add rule #2981

Conversation

ryo-ebata commented May 25, 2024 • edited by unvalley Loading

Summary

Test Plan

codspeed-hq bot commented May 25, 2024 • edited Loading

Merging #2981 will improve performances by 6.22%

Summary

Benchmarks breakdown

ryo-ebata commented Jun 2, 2024 • edited Loading

unvalley commented Jun 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ematipico Jun 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryo-ebata Jun 15, 2024 • edited Loading

Choose a reason for hiding this comment

ryo-ebata Jun 15, 2024 • edited Loading

Choose a reason for hiding this comment

ryo-ebata commented Jun 11, 2024

ematipico left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryo-ebata commented Jul 4, 2024

unvalley Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unvalley commented Jul 4, 2024 • edited Loading

unvalley commented Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unvalley left a comment

Choose a reason for hiding this comment

ryo-ebata commented Jul 7, 2024 • edited Loading

ryo-ebata commented May 25, 2024 •

edited by unvalley

Loading

codspeed-hq bot commented May 25, 2024 •

edited

Loading

ryo-ebata commented Jun 2, 2024 •

edited

Loading

unvalley commented Jun 3, 2024 •

edited

Loading

ematipico Jun 13, 2024 •

edited

Loading

ryo-ebata Jun 15, 2024 •

edited

Loading

ryo-ebata Jun 15, 2024 •

edited

Loading

unvalley Jul 4, 2024 •

edited

Loading

unvalley commented Jul 4, 2024 •

edited

Loading

unvalley commented Jul 4, 2024 •

edited

Loading

ryo-ebata commented Jul 7, 2024 •

edited

Loading