Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lint/noStaticElementInteractions): add rule #2981

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

feat(lint/noStaticElementInteractions): add rule #2981

wants to merge 40 commits into from
+2,030 −99

Commits on Jul 4, 2024

  1. feat(lint/noStaticElementInteractions): add rule

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f2c640f View commit details
    Browse the repository at this point in the history

  2. run just l

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c7a7380 View commit details
    Browse the repository at this point in the history

  3. rename: elm → element_name

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    97f3dcf View commit details
    Browse the repository at this point in the history

  4. refactor: inline has_truthy_ariahidden_attr method back into the main… 

    … function
    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    1d673ef View commit details
    Browse the repository at this point in the history

  5. refactor: add detail information

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    e87e6ca View commit details
    Browse the repository at this point in the history

  6. refactor: change HashMap to FxHashMap

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a0ef1f8 View commit details
    Browse the repository at this point in the history

  7. refactor: delete elements have non-interactive role from valid test case

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    30b9656 View commit details
    Browse the repository at this point in the history

  8. refactor: Swapped variable declarations

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    543bb54 View commit details
    Browse the repository at this point in the history

  9. Refactor: Remove redundant code

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    946fb34 View commit details
    Browse the repository at this point in the history

  10. fix: Modify AriaServices::extract_attributes to handle dynamic values

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    e9fe979 View commit details
    Browse the repository at this point in the history

  11. refactor: Inline is_interactive_handler_present logic into run an… 

    …d move `CATEGORIES_TO_CHECK` to const
    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a43203c View commit details
    Browse the repository at this point in the history

  12. refactor: modify markup text

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    9388e95 View commit details
    Browse the repository at this point in the history

  13. refactor: is role interactive check

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    7668481 View commit details
    Browse the repository at this point in the history

  14. add: code comment

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    4fb76f0 View commit details
    Browse the repository at this point in the history

  15. refactor: rule comments

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    0214f1c View commit details
    Browse the repository at this point in the history

  16. rebase

    @ematipico
    ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    835bc34 View commit details
    Browse the repository at this point in the history

  17. rebase and fix code blocks

    @ematipico
    ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    6e08a1e View commit details
    Browse the repository at this point in the history

  18. Update crates/biome_js_analyze/src/lint/nursery/no_static_element_int… 

    …eractions.rs
    @unvalley @ematipico
    unvalley authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    981aa46 View commit details
    Browse the repository at this point in the history

  19. fix: Commented out unnecessary overhead.

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    90d4bc9 View commit details
    Browse the repository at this point in the history

  20. refactor: Improved event handler mappings by using simple arrays and … 

    …added explanatory comments for better clarity and performance.
    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f68bd87 View commit details
    Browse the repository at this point in the history

  21. refactor: Use constant for SECTION_ARIA_ATTRIBUTES to improve efficiency

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    d0177c2 View commit details
    Browse the repository at this point in the history

  22. refactor: use text_trimmed() for dynamic attribute values in extract_… 

    …attributes function
    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    d31f8f1 View commit details
    Browse the repository at this point in the history

  23. feat: add is_hidden_from_screen_reader()

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    182eae0 View commit details
    Browse the repository at this point in the history

  24. feat: add is_not_static_element method

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    8f2039c View commit details
    Browse the repository at this point in the history

  25. refactor: run just l

    @ryo-ebata @ematipico
    ryo-ebata authored and ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    02c17a9 View commit details
    Browse the repository at this point in the history

  26. rebase

    @ematipico
    ematipico committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    6394998 View commit details
    Browse the repository at this point in the history

  27. refactor: delete commented out code

    @ryo-ebata
    ryo-ebata committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    7851727 View commit details
    Browse the repository at this point in the history

  28. refactor: new snap

    @ryo-ebata
    ryo-ebata committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    e530ffc View commit details
    Browse the repository at this point in the history

  29. refactor: use split_whitespace method

    @ryo-ebata
    ryo-ebata committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    2dcbc5e View commit details
    Browse the repository at this point in the history

  30. refactor: Corrected description

    @ryo-ebata
    ryo-ebata committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    cabbf1c View commit details
    Browse the repository at this point in the history

  31. Update crates/biome_js_analyze/src/lint/nursery/no_static_element_int… 

    …eractions.rs
    @unvalley
    unvalley committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    4b79dcd View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Merge branch 'main' into ryo-ebata/no-static-element-interactions

    @unvalley
    unvalley committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6c17137 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. refactor: delete redundant ref comments

    @ryo-ebata
    ryo-ebata committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    d09548f View commit details
    Browse the repository at this point in the history

  2. refactor: Change to even simpler code that works correctly

    @ryo-ebata
    ryo-ebata committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    7063f9b View commit details
    Browse the repository at this point in the history

  3. chore: apply codegen

    @ryo-ebata
    ryo-ebata committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    d559479 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. chore: run just l

    @ryo-ebata
    ryo-ebata committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d6f4ad3 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. fix: extract_attributes() return enum AttributeValue

    @ryo-ebata
    ryo-ebata committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    201af4f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ryo-ebata/no-static-element-interactions' of https://gi… 

    …thub.com/ryo-ebata/biome into ryo-ebata/no-static-element-interactions
    @ryo-ebata
    ryo-ebata committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ed851f1 View commit details
    Browse the repository at this point in the history

  3. chore: run just l, just f, just gen-lint, just gen-binding

    @ryo-ebata
    ryo-ebata committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    81c0e58 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ryo-ebata/no-static-element-interactions

    @ryo-ebata
    ryo-ebata committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d82f606 View commit details
    Browse the repository at this point in the history