refactor(analyzer): severity in metadata #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
ematipico
force-pushed
the
refactor/severity-via-metadata
branch
from
408531e
to
31c58bc
Compare
CodSpeed Performance ReportMerging #4634 will not alter performanceComparing Summary
|
arendjr
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #4626
This PR:
severityto theRuleMetaseverityto only recommended rules. The reason why I did this refactor was because we don't know yet which rules will be an error, a warning or an information, but as for now all the recommended rules we have, are supposed to raise an error, this isn't, technically, a breaking changeOf course, this is just a facade change because
severityisn't used yet. We will follow up with another PR to change the codegenTest Plan
Current CI should pass