-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset max stress level metric to minimum #216
base: develop
Are you sure you want to change the base?
Reset max stress level metric to minimum #216
Conversation
Build artifacts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comprehensive PR, makes sense in regards to making the behavior consistent.
I think it'd be important to adjust the EDT specs accordingly, since it's not specified in which timeframe context this status frame value is to be seen.
Ping @AlkaMotors - how do you handle the max stress level in the EDT status frame in AM32 - AFAIK you have that implemented too, no?
e99d053
to
554d016
Compare
Build artifacts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Current Behavior
The
Demag_Detected_Metric_Max
currently stores the maximum value observed since the ESC was armed. This results in the metric becoming static after reaching its peak, never decreasing until the ESC is disarmed.Proposed Change
Reset the
Demag_Detected_Metric_Max
metric each time a STATUS telemetry packet is sent. So that the value in a STATUS telemetry packet would represent the Max stress level in the last second (according to current scheduler implementation).Rationale
Tests
This is what 40 seconds of blackbox log look like if recorded with this change.