Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: Update to 28.0 #248

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

snap: Update to 28.0 #248

wants to merge 2 commits into from

Conversation

achow101
Copy link
Member

@achow101 achow101 commented Oct 4, 2024

No description provided.

@achow101 achow101 force-pushed the main branch 3 times, most recently from 2b6459b to 182774d Compare October 5, 2024 00:14
@maflcko
Copy link
Contributor

maflcko commented Oct 7, 2024

The guix builds require glibc 2.31 (bitcoin/bitcoin#29987 ). I am not sure how snap build works internally, but I think the tests are just run on the host system, using the host glibc. So you may have to bump .cirrus.yml

@achow101
Copy link
Member Author

achow101 commented Oct 7, 2024

So you may have to bump .cirrus.yml

I tried. Ubuntu >=20 can't install snapcraft to build the snap. Apparently snapcraft can't be installed in docker?

@maflcko
Copy link
Contributor

maflcko commented Oct 8, 2024

Yeah, it may require a docker-in-docker hack. An alternative may be to use a "real" vm, instead of a container. You could try by replacing container: image: ... with something like:

  compute_engine_instance:
    image_project: ubuntu-os-cloud
    image: family/ubuntu-2204-lts

@achow101
Copy link
Member Author

achow101 commented Oct 8, 2024

There appear to be GitHub actions for building a snap and pushing it to the snap store, perhaps we should switch to those. Would also simplify the release process to cut out launchpad.

@maflcko
Copy link
Contributor

maflcko commented Oct 8, 2024

Snaps can be compromised when launchpad is compromised (obviously). However, when using GHA to push the image, a snap can also be compromised by GHA. No strong opinion, but I wanted to mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants