PM-1688 | individual vault encryption: remove client version restriction

[merissaacosta]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-1688

📔 Objective

We are ready to remove the server restriction code for individual vault encryption since it has been more than 3 releases, in order to follow our versioning support plan: Versioning | Support .

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.91%. Comparing base (f045d06) to head (369ac7f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4198   +/-   ##
=======================================
  Coverage   40.90%   40.91%           
=======================================
  Files        1260     1260           
  Lines       60087    60076   -11     
  Branches     5486     5485    -1     
=======================================
- Hits        24580    24579    -1     
+ Misses      34373    34363   -10     
  Partials     1134     1134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – e911aecf-e1f4-4945-a21f-57fb4f2430d0

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 579	Attack Vector
	Privacy_Violation	/src/Api/Auth/Controllers/AccountsController.cs: 411	Attack Vector
	Privacy_Violation	/src/Api/Auth/Controllers/AccountsController.cs: 548	Attack Vector
	Privacy_Violation	/src/Api/Auth/Controllers/AccountsController.cs: 846	Attack Vector
	Privacy_Violation	/src/Api/Vault/Controllers/CiphersController.cs: 956	Attack Vector
	Privacy_Violation	/src/Api/Auth/Controllers/AccountsController.cs: 828	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117	Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 540	Attack Vector
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 948	Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 403	Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 838	Attack Vector
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 820	Attack Vector
	Missing_CSP_Header	/src/Core/MailTemplates/Handlebars/Auth/RegistrationVerifyEmail.html.hbs: 17	Attack Vector
	Open_Redirect	/src/Admin/Controllers/ToolsController.cs: 194	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 365
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 83
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 645
	CSRF	/src/Identity/Controllers/AccountsController.cs: 68
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 984
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 799
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 125
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 111
	CSRF	/src/Api/Auth/Controllers/AccountsController.cs: 453
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 730
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117
	Log_Forging	/src/Billing/Controllers/StripeController.cs: 117

[LRNcardozoWDF]

Just a minor fix, thank you.

[trmartin4]

This looks good. Thank you for cleaning it up! We will probably want to call out what this will do to older versions somehow in the release notes, but we are within our supported version policy by doing this.