Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-1688 | individual vault encryption: remove client version restriction #4198

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Api/Vault/Controllers/CiphersController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ public class CiphersController : Controller
private readonly ICurrentContext _currentContext;
private readonly ILogger<CiphersController> _logger;
private readonly GlobalSettings _globalSettings;
private readonly Version _cipherKeyEncryptionMinimumVersion = new Version(Constants.CipherKeyEncryptionMinimumVersion);
private readonly IFeatureService _featureService;
private readonly IOrganizationCiphersQuery _organizationCiphersQuery;
private readonly IApplicationCacheService _applicationCacheService;
Expand Down Expand Up @@ -1249,7 +1248,7 @@ private void ValidateAttachment()

private void ValidateClientVersionForItemLevelEncryptionSupport(Cipher cipher)
merissaacosta marked this conversation as resolved.
Show resolved Hide resolved
{
if (cipher.Key != null && _currentContext.ClientVersion < _cipherKeyEncryptionMinimumVersion)
if (cipher.Key != null)
{
throw new BadRequestException("Cannot edit item. Update to the latest version of Bitwarden and try again.");
}
Expand Down
2 changes: 0 additions & 2 deletions src/Core/Constants.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ public static class Constants

public const string Fido2KeyCipherMinimumVersion = "2023.10.0";

public const string CipherKeyEncryptionMinimumVersion = "2024.2.0";

/// <summary>
/// Used by IdentityServer to identify our own provider.
/// </summary>
Expand Down
Loading