[shaderc] Clean up #3258
Merged
[shaderc] Clean up #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion options from: https://developer.apple.com/documentation/metal/mtllanguageversion?language=objc Add configuration options for MSL compiler based on MSL version and Platform Configure MSL->SPIR-V version configuration based on when ray tracing types become available Set default metal compiler option to be metal 1.2, which is the default version assigned in the current SPIRV-Cross being used
…ion options from: https://developer.apple.com/documentation/metal/mtllanguageversion?language=objc Add configuration options for MSL compiler based on MSL version and Platform Configure MSL->SPIR-V version configuration based on when ray tracing types become available Set default metal compiler option to be metal 1.2, which is the default version assigned in the current SPIRV-Cross being used
Reduce the size of temp buffer used in writing the MSL preprocessor define Fix a compiler warning about size_t to int32_t truncation Adjust whitespace in usage text
…rm_configuration_in_shaderc
…derc' into shaderc_cleanup # Conflicts: # tools/shaderc/shaderc.cpp # tools/shaderc/shaderc_metal.cpp
|
There are conflicts. |
# Conflicts: # tools/shaderc/shaderc.cpp # tools/shaderc/shaderc_metal.cpp
They should all be resolved now. |
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
* Add Metal Shading Language version options to shaderc. Reference version options from: https://developer.apple.com/documentation/metal/mtllanguageversion?language=objc Add configuration options for MSL compiler based on MSL version and Platform Configure MSL->SPIR-V version configuration based on when ray tracing types become available Set default metal compiler option to be metal 1.2, which is the default version assigned in the current SPIRV-Cross being used * Add Metal Shading Language version options to shaderc. Reference version options from: https://developer.apple.com/documentation/metal/mtllanguageversion?language=objc Add configuration options for MSL compiler based on MSL version and Platform Configure MSL->SPIR-V version configuration based on when ray tracing types become available Set default metal compiler option to be metal 1.2, which is the default version assigned in the current SPIRV-Cross being used * Group ios and osx platform code paths Reduce the size of temp buffer used in writing the MSL preprocessor define Fix a compiler warning about size_t to int32_t truncation Adjust whitespace in usage text * Remove indented scope left-over from branch condition removal * Remove some testing code * Adjust whitespace for function arguments * Replace BX_ASSERT with bx::write to message handler in spirv generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency on first merging #3213