core: blueos_startup_update: load pi5 overlays in runtime #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
pi5_overlays
branch
from
a87848b
to
ae96b85
Compare
Williangalvani
force-pushed
the
pi5_overlays
branch
2 times, most recently
from
060e44a
to
771ec3a
Compare
patrickelectric
requested changes
May 31, 2024
Comment on lines
443
to
445
| loaded_overlays = [overlay.split(": ")[1].strip() for overlay in loaded_overlays if ": " in overlay] | ||
| loaded_overlay_names = [overlay.split(" ")[0] for overlay in loaded_overlays if "dtparam" not in overlay] | ||
| loaded_dt_params = [overlay.split(" ")[-1] for overlay in loaded_overlays if "dtparam" in overlay] |
There was a problem hiding this comment.
I would recommend using a simple regex over doing this logic, it'll be simpler and more readable.
^(?<index>\d):\s+(?<name>\S+)($|\s+(?<args>.*))
There was a problem hiding this comment.
I agree with Patrick here, it's easier to follow the parsing from the regex line.
Williangalvani
force-pushed
the
pi5_overlays
branch
6 times, most recently
from
f106745
to
011283a
Compare
|
I re-wrote most of it to do it right. it is a lot more code, but it should also be a lot more robust, and easier to follow. |
Williangalvani
force-pushed
the
pi5_overlays
branch
2 times, most recently
from
ca17422
to
9eef311
Compare
patrickelectric
requested changes
May 31, 2024
Williangalvani
force-pushed
the
pi5_overlays
branch
from
9eef311
to
695bf1d
Compare
Williangalvani
force-pushed
the
pi5_overlays
branch
from
695bf1d
to
dfda0e9
Compare
yes, that is the current plan |
|
|
||
| @staticmethod | ||
| def from_string(overlay: str) -> "Overlay": | ||
| match = re.match(r"^((?P<index>\d+):\s+)?(?P<name>(\S)+)(?:$|\s+(?P<args>.*))", overlay) |
There was a problem hiding this comment.
Can we extract this line into a class method so we can call it on line 127 instead of having the regex duplicated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.