Add support for python 3 & 2.7 #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjstein
commented
Apr 9, 2020
•
sjstein
commented
- Updated for Python 2.7 / 3.x compatibility to address issue Python 3 support #9
* Updated for Python 3 and Python 2.7 compatibility
|
All of your changes look good to me. They are a few more comments in the main function that need to have parenthesis's added but that is easy enough to do. I ended up writing the exact same changes to get my depth sensor to work with python 3 before I saw this pull request. Hopefully someone one day will eventually accept it. Perhaps the best thing would to make a new folder with python3 vs python2 scripts so users can select between either one? |
|
I merged #15 in favor of this one. Thank you for the patch, sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.