-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add a priority score value for ozone subjects #3495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty straight forward
if (minPriorityScore != null && minPriorityScore > 0) { | ||
builder = builder.where( | ||
'moderation_subject_status.priorityScore', | ||
'>=', | ||
minPriorityScore, | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we don't want to allow priorityScore
to be 0
?
This would allow to distinguish "items with a priority score defined" from items "without a priority score (priority unknown)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good point, I don't see a use-case for this right now but doesn't hurt to allow it.
This PR allows moderators to set an arbitrary numeric value to any subject, as its priority score. Then, when querying statuses, subjects can be sorted by this value.