-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge upstream master #8
Open
bill-auger
wants to merge
178
commits into
bonzini:master
Choose a base branch
from
bill-auger:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user of the get_attributes_array is working on the message OOP, no need to get the message and not use it. 2013-02-24 Holger Hans Peter Freyther <[email protected]> * libgst/dict.c: Remove ATTRIBUTE_HIDDEN from static methods. * libgst/comp.c: Remove unused variables in get_attributes_array. * libgst/save.c: Remove unused variable in make_oop_table_to_be_saved.
The disassemble function was never called, the opcode code is outdated, GNU lightning gained functionality to do the disassembly. For debugging implementing the GNU GDB JIT interface might be easier. 2013-01-21 Gwenael Casaccio <[email protected]> * main.c: Remove ENABLE_DISASSEMBLER support * opcode/dis-buf.c: Delete * opcode/disass.c: Delete * opcode/i386-dis.c: Delete * opcode/ppc-dis.c: Delete * opcode/ppc-opc.c: Delete * opcode/sparc-dis.c: Delete * opcode/sparc-opc.c: Delete
2013-03-04 Holger Hans Peter Freyther <[email protected]> * kernel/PkgLoader.st: Remove unused variable.
Fix two problems introduced by the RBNumberLiteralToken change. The first one is to use >>#copyFrom:to: instead of re-positioning the stream to fix an issue with the ConcatenatedStream and the second is to pick the right stop for the token. Code like '(Delay forSeconds: 3) wait' got re-formatted to '(Delay forSeconds: 3)) wait'. The code that extracts the sourcecode for the RBNumberLiteralToken should have operated on the result of >>#previousStepPosition but instead the current position of stream was used as an end. Use self previousStepPosition to find the end of the number literal, remove unused variables and remove the trimSeparators as we are now using the right place to stop. 2013-02-17 Holger Hans Peter Freyther <[email protected]> * RBParser.st: Fix RBScanner>>#scanNumber. * RewriteTests.st: Add testcase for RBScanner>>#scanNumber. * package.xml: Add the new test to the testsuite.
Negative numbers are not directly parsed in the RBScanner>>#scanNumber but are made negative from within the RBParser>>#parseNegatedNumber. This was done to help to differentiate a binary selector from the number. Add a testcase for the formatting, make the number negative inside the number literal token and prepend the $- to the source. The start/stop of the token has been wrong before this commit and is still wrong. This needs to be fixed in the future.
…e alignment 2013-04-25 Holger Hans Peter Freyther <[email protected]> * libgst/md-config.h: Add cases for the ARM architecture.
(STInST.STClassLoaderObjects.ProxyNamespace on: Smalltalk for: STInST.STClassLoader new) displayString triggered a DNU for classNameString and after fixing that it ended with an infinite recursion as the value is self. Avoid the recursion. 2013-03-31 Holger Hans Peter Freyther <[email protected]> * tests/stcompiler.ok: Update the test result. * tests/stcompiler.st: Add a testcase for ProxyNamespace>>#printOn:. 2013-03-31 Holger Hans Peter Freyther <[email protected]> * STLoaderObjs.st: Change ProxyNamespace>>#printOn to avoid recursion into self.
The current code is loading all rows of a select into the memory. For my application this consumes too much memory. SQLite3 does not support to query the size of the result set. This means that >>#rowSize can not determine the size of the result set. When using the >>#next/>>#atEnd selectors the >>#rowSize will not be available. When using >>#rows/>>#rowSize/>>#size before any other query will result in all results to be fetched.
Add a way to load a Package from the package.xml and not go through the creation of a star file. This can make developing with packages more effective. 2013-03-24 Holger Hans Peter Freyther <[email protected]> * libgst/files.c: Add DirPackage.st to the bootstrap. * kernel/DirPackage.st: Add new file with the DirPackage class and extension to the PackageLoader. * kernel/PkgLoader.st: Refactor and create ExternalPackage base class.
This will hold non UI tools to help with tooling. This can be linters, the converter, package related tools. Begin with moving parts of the gst-convert code into this package. 2013-03-30 Holger Hans Peter Freyther <[email protected]> * configure.ac: Introduce the STTools package. 2013-03-30 Holger Hans Peter Freyther <[email protected]> * Makefile.frag: Added. * Parser/SourceClass.st: Added from scripts/Convert.st. * Parser/SourceComments.st: Added from scripts/Convert.st. * Parser/SourceEntity.st: Added from scripts/Convert.st. * Parser/SourceEval.st: Added from scripts/Convert.st. * Parser/Loader.st: Added from scripts/Convert.st. * README: Added. * TODO: Added. * package.xml: Added.
* doc/tutorial.texi: Simply by substituting an instance of '@itemx' with an instance of '@item' in this file. Copyright-paperwork-exempt: yes Signed-off-by: Stefano Lattarini <[email protected]>
Enable the mysql service, start it and create a database for the unit test. The script needs to set a password for the MySQL user as GST can not create a connection with a 'blank' password.
Disabling the prefetching is a win on arm9 (arm926ejs, e.g. TI Davinci DM644x). This was benchmarked using the simple Bench.st benchmark. 2013-04-28 Holger Hans Peter Freyther <[email protected]> * libgst/gstpriv.h: Allow to disable the DO_PREFETCH.
This is more noticable on smaller devices. Allow to disable the line number bytecode. This changes the runtime of Bench.st for 4 iterations from 26s to 19s on a TI Davinci DM 644x. 2013-05-18 Holger Hans Peter Freyther <[email protected]> * gst-tool.c: Add --no-line-numbers to the gst-remote command. * main.c: Add --no-line-numbers to the gst command. 2013-05-18 Holger Hans Peter Freyther <[email protected]> * libgst/byte.c: Define _gst_omit_line_numbers, emit line numbers depending on this variable. * libgst/files.h: Declare the _gst_omit_line_numbers variable. * libgst/gst.h: Introduce GST_NO_LINE_NUMBERS. * libgst/interp.c: Implement get and set of GST_NO_LINE_NUMBERS.
On AMD64/FreeBSD 9.1 the GNU libiconv library does not know about 'utf8' and iconv_open returned an invalid handle address. The code attempts to detect cases of the handle being equal to (iconv_t) -1 but this didn't work on AMD64 systems. Add a C-Function to query the value of (iconv_t) -1 to make the code work for various pointer sizes. Grease is using 'utf8' as codec name but GNU libiconv does not have support to match this to 'UTF-8'. Add some support code to replace the codec name before calling iconv_open. Introduce a >>#isValid that checks the iconvHandle for isNil or the address for being an invalid handle. This should fix a potential crash when saving an invalid handle and calling release on it. 2013-05-20 Holger Hans Peter Freyther <[email protected]> * Sets.st: Add >>#isValid, >>#codecReplace: and >>#iconvInvalidHandle. * iconv.c: Add iconvInvalid C-Function. * iconvtests.st: Add test for 'utf8' replacement.
When you're on the class browser select Object and show the class hierarchy as a result you'll see all the metaclasses. 2013-06-02 Gwenael Casaccio <[email protected]> * StBrowser/GtkClassHierarchyWidget.st: Fix GtkClassHierarchyWidget>>#classOrMeta: and GtkClassHierarchyWidget>>#buildTreeView. Signed-off-by: Holger Hans Peter Freyther <[email protected]>
The compiler/runtime is optimizing returns of instance variables and we can use that here. 2013-06-06 Gwenael Casaccio <[email protected]> * kernel/ContextPart.st: Remove useless optimizations.
In emacs-24.2 The inhibit-first-line-modes-regexps variable was renamed to inhibit-local-variables-regexps. 2013-06-14 Jochen Schmitt <[email protected]> * smalltalk-mode-init.el.in: Use inhibit-local-variables-regexps if it is available.
2013-06-14 Gwenael Casaccio <[email protected]> * libgst/dict.c: Remove useless code: gst_ordered_collection structure. * libgst/dict.inl: Remove useless code: ordered_collection_begin and ordered_collection_end.
2013-06-17 Gwenael Casaccio <[email protected]> * AbstractFinder.st: Add copyright header. * Category/AbstractNamespace.st: Add copyright header. * Category/Class.st: Add copyright header. * Category/ClassCategory.st: Add copyright header. * ClassFinder.st: Add copyright header. * Clock/GtkClock.st: Add copyright header. * Commands/CategoryMenus/AddCategoryCommand.st: Add copyright header. * Commands/CategoryMenus/CategoryCommand.st: Add copyright header. * Commands/CategoryMenus/FileoutCategoryCommand.st: Add copyright header. * Commands/CategoryMenus/RenameCategoryCommand.st: Add copyright header. * Commands/ClassMenus/AddClassCommand.st: Add copyright header. * Commands/ClassMenus/ClassCommand.st: Add copyright header. * Commands/ClassMenus/DeleteClassCommand.st: Add copyright header. * Commands/ClassMenus/FileoutClassCommand.st: Add copyright header. * Commands/ClassMenus/InspectClassCommand.st: Add copyright header. * Commands/ClassMenus/RenameClassCommand.st: Add copyright header. * Commands/Command.st: Add copyright header. * Commands/DebugMenus/ContinueDebugCommand.st: Add copyright header. * Commands/DebugMenus/DebugCommand.st: Add copyright header. * Commands/DebugMenus/StepIntoDebugCommand.st: Add copyright header. * Commands/DebugMenus/StepToDebugCommand.st: Add copyright header. * Commands/EditMenus/CancelEditCommand.st: Add copyright header. * Commands/EditMenus/CopyEditCommand.st: Add copyright header. * Commands/EditMenus/CutEditCommand.st: Add copyright header. * Commands/EditMenus/FindEditCommand.st: Add copyright header. * Commands/EditMenus/PasteEditCommand.st: Add copyright header. * Commands/EditMenus/RedoEditCommand.st: Add copyright header. * Commands/EditMenus/ReplaceEditCommand.st: Add copyright header. * Commands/EditMenus/SelectAllEditCommand.st: Add copyright header. * Commands/EditMenus/UndoEditCommand.st: Add copyright header. * Commands/FileCommands/CloseToolCommand.st: Add copyright header. * Commands/FileCommands/FileOpenCommand.st: Add copyright header. * Commands/FileCommands/FileSaveAsCommand.st: Add copyright header. * Commands/FileCommands/FileSaveCommand.st: Add copyright header. * Commands/FileCommands/QuitToolCommand.st: Add copyright header. * Commands/HistoryCommands/HistoryBackCommand.st: Add copyright header. * Commands/HistoryCommands/HistoryDisplayCommand.st: Add copyright header. * Commands/HistoryCommands/HistoryForwardCommand.st: Add copyright header. * Commands/InspectorMenus/InspectorBackCommand.st: Add copyright header. * Commands/InspectorMenus/InspectorDiveCommand.st: Add copyright header. * Commands/MethodMenus/DebugTestCommand.st: Add copyright header. * Commands/MethodMenus/DeleteMethodCommand.st: Add copyright header. * Commands/MethodMenus/FileoutMethodCommand.st: Add copyright header. * Commands/MethodMenus/InspectMethodCommand.st: Add copyright header. * Commands/MethodMenus/MethodCommand.st: Add copyright header. * Commands/NamespaceMenus/AddNamespaceCommand.st: Add copyright header. * Commands/NamespaceMenus/DeleteNamespaceCommand.st: Add copyright header. * Commands/NamespaceMenus/FileoutNamespaceCommand.st: Add copyright header. * Commands/NamespaceMenus/InspectNamespaceCommand.st: Add copyright header. * Commands/NamespaceMenus/NamespaceCommand.st: Add copyright header. * Commands/NamespaceMenus/RenameNamespaceCommand.st: Add copyright header. * Commands/OpenBrowserCommand.st: Add copyright header. * Commands/OpenTabbedBrowserCommand.st: Add copyright header. * Commands/OpenWorkspaceCommand.st: Add copyright header. * Commands/SaveImageAsCommand.st: Add copyright header. * Commands/SaveImageCommand.st: Add copyright header. * Commands/SmalltalkMenus/AcceptItCommand.st: Add copyright header. * Commands/SmalltalkMenus/CancelCommand.st: Add copyright header. * Commands/SmalltalkMenus/DebugItCommand.st: Add copyright header. * Commands/SmalltalkMenus/DoItCommand.st: Add copyright header. * Commands/SmalltalkMenus/InspectItCommand.st: Add copyright header. * Commands/SmalltalkMenus/PrintItCommand.st: Add copyright header. * Commands/TabsMenus/CloseTabCommand.st: Add copyright header. * Commands/TabsMenus/NextTabCommand.st: Add copyright header. * Commands/TabsMenus/PreviousTabCommand.st: Add copyright header. * Commands/ToolsMenus/OpenAssistantCommand.st: Add copyright header. * Commands/ToolsMenus/OpenBottomPaneCommand.st: Add copyright header. * Commands/ToolsMenus/OpenImplementorCommand.st: Add copyright header. * Commands/ToolsMenus/OpenPackageBuilderCommand.st: Add copyright header. * Commands/ToolsMenus/OpenSUnitCommand.st: Add copyright header. * Commands/ToolsMenus/OpenSenderCommand.st: Add copyright header. * Commands/ToolsMenus/OpenWebBrowserCommand.st: Add copyright header. * Commands/WorkspaceMenus/DeleteItemCommand.st: Add copyright header. * Commands/WorkspaceMenus/InspectItemCommand.st: Add copyright header. * Commands/WorkspaceMenus/WorkspaceVariableCommand.st: Add copyright header. * Debugger/GtkContextWidget.st: Add copyright header. * Debugger/GtkDebugger.st: Add copyright header. * Debugger/GtkStackInspector.st: Add copyright header. * Debugger/GtkStackInspectorView.st: Add copyright header. * Extensions.st: Add copyright header. * FakeNamespace.st: Add copyright header. * GtkAbstractConcreteWidget.st: Add copyright header. * GtkAnnouncer.st: Add copyright header. * GtkAssistant.st: Add copyright header. * GtkBrowsingTool.st: Add copyright header. * GtkClassSUnitWidget.st: Add copyright header. * GtkClassSelectionChanged.st: Add copyright header. * GtkConcreteWidget.st: Add copyright header. * GtkEntryDialog.st: Add copyright header. * GtkEntryWidget.st: Add copyright header. * GtkHSidebarWidget.st: Add copyright header. * GtkHistoryWidget.st: Add copyright header. * GtkLauncher.st: Add copyright header. * GtkListModel.st: Add copyright header. * GtkMainWindow.st: Add copyright header. * GtkMethodSUnitWidget.st: Add copyright header. * GtkNamespaceSelectionChanged.st: Add copyright header. * GtkNotebookWidget.st: Add copyright header. * GtkPackageBuilderWidget.st: Add copyright header. * GtkScrollTreeWidget.st: Add copyright header. * GtkSidebarWidget.st: Add copyright header. * GtkSimpleListWidget.st: Add copyright header. * GtkTranscriptWidget.st: Add copyright header. * GtkTreeModel.st: Add copyright header. * GtkVSidebarWidget.st: Add copyright header. * GtkVariableTrackerWidget.st: Add copyright header. * GtkVisualGSTTool.st: Add copyright header. * GtkWebBrowser.st: Add copyright header. * GtkWebView.st: Add copyright header. * GtkWorkspaceWidget.st: Add copyright header. * HistoryStack.st: Add copyright header. * Image/GtkImageModel.st: Add copyright header. * Image/GtkImageWidget.st: Add copyright header. * Implementors/GtkImageResultsWidget.st: Add copyright header. * Implementors/GtkImplementorResultsWidget.st: Add copyright header. * Implementors/GtkSenderResultsWidget.st: Add copyright header. * Inspector/GtkCharacterInspectorView.st: Add copyright header. * Inspector/GtkCompiledBlockInspectorView.st: Add copyright header. * Inspector/GtkCompiledMethodInspectorView.st: Add copyright header. * Inspector/GtkDictionaryInspectorView.st: Add copyright header. * Inspector/GtkFloatInspectorView.st: Add copyright header. * Inspector/GtkInspector.st: Add copyright header. * Inspector/GtkInspectorBrowserWidget.st: Add copyright header. * Inspector/GtkInspectorSourceWidget.st: Add copyright header. * Inspector/GtkInspectorWidget.st: Add copyright header. * Inspector/GtkIntegerInspectorView.st: Add copyright header. * Inspector/GtkObjectInspectorView.st: Add copyright header. * Inspector/GtkSequenceableCollectionInspectorView.st: Add copyright header. * Inspector/GtkSetInspectorView.st: Add copyright header. * Menus/CategoryMenus.st: Add copyright header. * Menus/ClassMenus.st: Add copyright header. * Menus/ContextMenus.st: Add copyright header. * Menus/DebuggerToolbar.st: Add copyright header. * Menus/EditMenus.st: Add copyright header. * Menus/HistoryMenus.st: Add copyright header. * Menus/InspectorMenus.st: Add copyright header. * Menus/LauncherToolbar.st: Add copyright header. * Menus/MenuBuilder.st: Add copyright header. * Menus/MenuSeparator.st: Add copyright header. * Menus/MethodMenus.st: Add copyright header. * Menus/NamespaceMenus.st: Add copyright header. * Menus/SimpleWorkspaceMenus.st: Add copyright header. * Menus/SmalltalkMenus.st: Add copyright header. * Menus/TabsMenus.st: Add copyright header. * Menus/TextMenus.st: Add copyright header. * Menus/ToolbarSeparator.st: Add copyright header. * Menus/ToolsMenus.st: Add copyright header. * Menus/WorkspaceMenus.st: Add copyright header. * Menus/WorkspaceVariableMenus.st: Add copyright header. * MethodFinder.st: Add copyright header. * Model/GtkColumnOOPType.st: Add copyright header. * Model/GtkColumnPixbufType.st: Add copyright header. * Model/GtkColumnTextType.st: Add copyright header. * Model/GtkColumnType.st: Add copyright header. * NamespaceFinder.st: Add copyright header. * Notification/AbstractEvent.st: Add copyright header. * Notification/AddedEvent.st: Add copyright header. * Notification/CommentedEvent.st: Add copyright header. * Notification/DoItEvent.st: Add copyright header. * Notification/EventDispatcher.st: Add copyright header. * Notification/EventMultiplexer.st: Add copyright header. * Notification/Kernel/AbstractNamespace.st: Add copyright header. * Notification/Kernel/Class.st: Add copyright header. * Notification/Kernel/Metaclass.st: Add copyright header. * Notification/Kernel/MethodDictionary.st: Add copyright header. * SUnit/GtkSUnit.st: Add copyright header. * SUnit/GtkSUnitResultWidget.st: Add copyright header. * SUnit/TestBacktraceLog.st: Add copyright header. * Source/AutomaticFileOut.st: Add copyright header. * Source/BrowserMethodSource.st: Add copyright header. * Source/CategorySource.st: Add copyright header. * Source/ClassHeaderSource.st: Add copyright header. * Source/ClassSource.st: Add copyright header. * Source/MethodSource.st: Add copyright header. * Source/NamespaceHeaderSource.st: Add copyright header. * Source/NamespaceSource.st: Add copyright header. * Source/PackageSource.st: Add copyright header. * Source/SourceFormatter.st: Add copyright header. * StBrowser/GtkCategorizedClassWidget.st: Add copyright header. * StBrowser/GtkCategorizedNamespaceWidget.st: Add copyright header. * StBrowser/GtkCategoryWidget.st: Add copyright header. * StBrowser/GtkClassBrowserWidget.st: Add copyright header. * StBrowser/GtkClassHierarchyWidget.st: Add copyright header. * StBrowser/GtkMethodWidget.st: Add copyright header. * State/BrowserState.st: Add copyright header. * State/CategoryState.st: Add copyright header. * State/ClassState.st: Add copyright header. * State/MethodState.st: Add copyright header. * State/NamespaceState.st: Add copyright header. * SyntaxHighlighter.st: Add copyright header. * Tests/AddClassUndoCommandTest.st: Add copyright header. * Tests/AddNamespaceUndoCommandTest.st: Add copyright header. * Tests/CategoryTest.st: Add copyright header. * Tests/CompiledMethodTest.st: Add copyright header. * Tests/EmptyTest.st: Add copyright header. * Tests/ExtractLiteralsTest.st: Add copyright header. * Tests/FinderTest.st: Add copyright header. * Tests/GtkAssistantTest.st: Add copyright header. * Tests/GtkCategorizedClassWidgetTest.st: Add copyright header. * Tests/GtkCategorizedNamespaceWidgetTest.st: Add copyright header. * Tests/GtkCategoryWidgetTest.st: Add copyright header. * Tests/GtkConcreteWidgetTest.st: Add copyright header. * Tests/GtkMethodWidgetTest.st: Add copyright header. * Tests/GtkScrollTreeWidgetTest.st: Add copyright header. * Tests/GtkSimpleListWidgetTest.st: Add copyright header. * Tests/MenuBuilderTest.st: Add copyright header. * Tests/PragmaTest.st: Add copyright header. * Tests/StateTest.st: Add copyright header. * Tetris/HighScores.st: Add copyright header. * Tetris/Score.st: Add copyright header. * Text/GtkFindWidget.st: Add copyright header. * Text/GtkReplaceWidget.st: Add copyright header. * Text/GtkSaveTextWidget.st: Add copyright header. * Text/GtkSourceCodeWidget.st: Add copyright header. * Text/GtkTextPluginWidget.st: Add copyright header. * Text/GtkTextWidget.st: Add copyright header. * Undo/AddClassUndoCommand.st: Add copyright header. * Undo/AddMethodUndoCommand.st: Add copyright header. * Undo/AddNamespaceUndoCommand.st: Add copyright header. * Undo/DeleteClassUndoCommand.st: Add copyright header. * Undo/DeleteMethodUndoCommand.st: Add copyright header. * Undo/DeleteNamespaceUndoCommand.st: Add copyright header. * Undo/RenameCategoryUndoCommand.st: Add copyright header. * Undo/RenameClassUndoCommand.st: Add copyright header. * Undo/RenameNamespaceUndoCommand.st: Add copyright header. * Undo/Text/DeleteTextCommand.st: Add copyright header. * Undo/Text/InsertTextCommand.st: Add copyright header. * Undo/Text/ReplaceTextCommand.st: Add copyright header. * WorkspaceVariableTracker.st: Add copyright header.
The AddClassCommand (and others) use VisualGST.GtkEntryDialog>>#result to get the string. The >>#result selector is calling >>#getText on the GTK.GTKEntry but this does not exist. Add it now. 2013-06-17 Gwenael Casaccio <[email protected]> * Gtk/GtkEntry.st: GtkEntry support * Gtk/GtkEntryBuffer.st: GtkEntry support * package.xml: Update
Make them subclass of Command. Smalltalk commands don't works as undoable commands, they could only be executed: a simple eval in the workspace could break the undo/redo code. 2013-06-17 Gwenael Casaccio <[email protected]> * Commands/System/AddClassCommand.st: New system command * Commands/System/AddMethodCommand.st: New system command * Commands/System/AddNamespaceCommand.st: New system command * Commands/System/DeleteClassCommand.st: New system command * Commands/System/DeleteMethodCommand.st: New system command * Commands/System/DeleteNamespaceCommand.st: New system command * Commands/System/RenameCategoryCommand.st: New system command * Commands/System/RenameClassCommand.st: New system command * Commands/System/RenameNamespaceCommand.st: New system command * Commands/CategoryMenus/RenameCategoryCommand.st: Updated to new system command * Commands/ClassMenus/AddClassCommand.st: Updated to new system command * Commands/ClassMenus/DeleteClassCommand.st: Updated to new system command * Commands/ClassMenus/RenameClassCommand.st: Updated to new system command * Commands/Command.st: Updated to new system command * Commands/MethodMenus/DeleteMethodCommand.st: Updated to new system command * Commands/NamespaceMenus/AddNamespaceCommand.st: Updated to new system command * Commands/NamespaceMenus/DeleteNamespaceCommand.st: Updated to new system command * Commands/NamespaceMenus/RenameNamespaceCommand.st: Updated to new system command * Commands/SmalltalkMenus/AcceptItCommand.st: Updated to new system command * Undo/AddClassUndoCommand.st: Deleted * Undo/AddMethodUndoCommand.st: Deleted * Undo/AddNamespaceUndoCommand.st: Deleted * Undo/DeleteClassUndoCommand.st: Deleted * Undo/DeleteMethodUndoCommand.st: Deleted * Undo/DeleteNamespaceUndoCommand.st: Deleted * Undo/RenameCategoryUndoCommand.st: Deleted * Undo/RenameClassUndoCommand.st: Deleted * Undo/RenameNamespaceUndoCommand.st: Deleted * package.xml: Update
…ugger Make the debugger skip frames that belong to the system exception handling. This way a simple '3 halt' will stop in the frame that signals the exception, e.g. Halt(Exception)>>signal. In the future a preference will be added to allow to see all the frames. 2013-06-18 Gwenael Casaccio <[email protected]> * Debugger/Extensions.st: Added. * Debugger/GtkDebugger.st: Skip exception handling frames. * Extensions.st: Remove the debugger extension. * package.xml: Update
On x86/amd64 this will call mprotect with PROT_EXEC on the allocated memory. This is fixing an infinite recursion in the segfault handler of the garbage collection. 2013-06-03 Holger Hans Peter Freyther <[email protected]> * xlat.c: Use jit_flush_code for the runtime code.
CharacterArray>>#withWindowsShellEscapes has the following code that will lead to execution during the bootstrap. The interpreter is optimizing the calls for >>#value: but the JIT is not doing that. Change the order of the bootstrap to load the BlockClosure and related classes before the CharacterArray. table := ##( | t | t := ByteArray new: 256. #($% $" $< $> $| $& $^ $ ) do: [ :each | t at: each codePoint put: 1 ]. t). 2013-06-03 Holger Hans Peter Freyther <[email protected]> * files.c: Make BlockClosure available before the CharacterArray.
The tests crash when returning to a previous context. In the case of the Magritte test it is crashing on return to Delay class>>#runDelayProcess. This appears to occur when resuming an existing image. It is because the F_XLAT and F_XLAT_REACHABLE flags are cleared on saving of the image. On image resume the refresh_native_ips method will re-generate the native code and set the F_XLAT flag for active contexts. As the native code is not executed the F_XLAT_REACHABLE will not be set. This makes it possible for maybe_release_xlat to release the native code without updating the context. This will eventually cause a segmentation fault as the native code is gone. The solution appears to be easy. Once the native_ip is updated the F_XLAT_REACHABLE is set. This way it is guaranteed that the native code will not be collected. 2013-06-10 Holger Hans Peter Freyther <[email protected]> * interp-jit.inl: Set the F_XLAT_REACHABLE flag in refresh_native_ips.
Paolo writes: The point is not to optimize #ip and #sp. It is to _prevent_ optimizing it, and ensure that the cached values are committed by the interpreter to the object before reading the variable. This reverts commit 427e486. 2013-06-27 Holger Hans Peter Freyther <[email protected]> * kernel/ContextPart.st: Revert the previous change.
The above selector is needed for Phexample and in general very nice to debug failures as the result and expectation is immediately visible in the debugger. 2013-05-11 Holger Hans Peter Freyther <[email protected]> * packages/sunit/SUnit.st: Add #assert:equals: and #comparingStringBetween:and: from Pharo to the TestCase.
2014-04-09 In-Ho Yi <[email protected]> * sysdep/cygwin/findexec.c: Use cygwin_conv_path instead of cygwin_conv_to_posix_path for path conversion.
2014-04-02 Gwenael Casaccio <[email protected]> * STCompiler.st: Support keyword attributes. * STCompilerTests.st: Test for method attributes.
Remove unnecessary length check. Cygwin path conversion api which now gives error code. 2014-04-16 In-Ho Yi <[email protected]> * sysdep/cygwin/findexec.c: Update comment and change the error handling.
Using "gst-sunit -p PACKAGE" will execute all tests of the package. Make it possible to pass a different test script on the command line and in this case none of the default tests will be executed. This can be used when just trying to understand a single regression. 2014-05-01 Holger Hans Peter Freyther <[email protected]> * scripts/Test.st: Introduce pkgScript variable and use it.
Debugging "3 negated" and pressing "F7" could result in a live-lock. While the dispatch routine of the mainloop was ran the call-in process could wait on the "finalSemaphore" and the "idle" process would be selected to execute as the only process that remained runnable. This live-lock would never be exited. The underlying issue is that VisualGST is running in the same image and can be impacted by the execution of the debugged process. The only thing we can do right now is to skip dangerous routines. Currently the dangerous routines are related to the handling of finalizers as the Glib/Gtk+ bindings create a lot of to be finalized objects. 2014-05-05 Holger Hans Peter Freyther <[email protected]> * Debugger/GtkDebugger.st: Introduce >>#finishDangerousContexts and call it from >>#debugWith:.
The build fails if the netlink module is not available. Add a dummy file like it was done for zlib.
CPPFunction was deprecated in readling-4.2. Stop using the old symbol and update the autoconf test. 2014-05-26 Holger Hans Peter Freyther <[email protected]> * input.c: Use rl_quote_func_t, rl_dequote_func_t and rl_completion_func_t instead of the deprecated CPPFunction
Use Tcl_GetStringResult(interp) instead of interp->result on newer versions of Tcl. It looks like Tcl_GetStringResult has been present in the entire 8.0 series. 2014-05-26 Holger Hans Peter Freyther <[email protected]> * BloxTK.c: Use Tcl_GetStringResult to access the result.
In case the lock is not locked by the current process yet >>#critical: will not return value of the block. This is different to how Semaphore>>#critical: works. Fix it and add a testcase for both cases. 2014-06-21 Holger Hans Peter Freyther <[email protected]> * kernel/RecursionLock.st: Return the result of >>#critical: 2014-06-21 Holger Hans Peter Freyther <[email protected]> * kernel/RecursionLockTests.st: Add test for RecursionLock
This reverts commit 44cd50b. The snooper code doesn't appear to work correctly and seems to deadlock when a message is being added to the transcript. (ip 6)<unwind> BlockClosure>>#ensure: (ip 6)[] in RecursionLock>>#critical: (ip 30)[] in Semaphore>>#critical: (ip 6)<unwind> BlockClosure>>#ensure: (ip 8)Semaphore>>#critical: (ip 14)RecursionLock>>#critical: (ip 6)TextCollector>>#next:putAll:startingAt: (ip 14)String(SequenceableCollection)>>#nextPutAllOn: (ip 8)TextCollector(Stream)>>#nextPutAll: (ip 12)SmallInteger(Integer)>>#displayOn: (ip 8)TextCollector(Stream)>>#display: (ip 100)MethodContext>>#printOn:line: (ip 8)MethodContext>>#printOn: (ip 30)MethodContext(ContextPart)>>#backtraceOn: (ip 8)MethodContext(ContextPart)>>#backtrace (ip 6)[] in KeySnooper>>#initialize (ip 16)WrongClass(Exception)>>#activateHandler: (ip 24)WrongClass(Exception)>>#signal (ip 40)WrongClass class>>#signalOn:mustBe: (ip 24)WrongClass class>>#signalOn:mustBe: (ip 10)GdkEventKey(CObject)>>#address: (ip 8)GdkEventKey class(CObject class)>>#address: (ip 8)[] in KeySnooper>>#initialize (ip 12)<unwind> BlockClosure>>#on:do: (ip 10)[] in KeySnooper>>#initialize (ip 0)<bottom> 2014-07-20 Holger Hand Peter Freyther <[email protected]> * Misc/KeySnooper.st: Remove the file. * Misc/TaskQueue.st: Remove the >>#flush selector. * GtkLauncher.st: Remove invocation of KeySnooper.
It was possible that while we started to show the VisualGST window GTK+ would call back into Smalltalk and we would run the Glib dispatch while showing the window. This lead to a timer expiring on a non-fully realized window and leading to a crash inside GTK+/X11. Run the event loop after we have intitialized all of the VisualGST code. 2014-07-20 Holger Hans Peter Freyther <[email protected]> * scripts/Test.st: Spawn the event loop last.
In Pharo it is common that new/new: will already go through an initialize call. When porting code from and to Pharo one needs to make sure that initialize is called and only called once or idempotent. Align the code with Pharo. Remove redundant >>#new implementations throughout the packages include in GNU Smalltalk. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * examples/PackageBuilder.st: Remove PackageBuilder class >>#new. * kernel/Builtins.st: Add Object>>#initialize, change Behavior>>#new and Behavior>>#new:. * kernel/CompildCode.st: Remove CompildCode>>#initialize. * kernel/Metaclass.st: Add Metaclass>>#new. * kernel/PkgLoader.st: Remove PackageDirectories class >> #new. * kernel/RecursionLock.st: Remove RecursionLock class >> #new. * kernel/Semaphore.st: Remove Semaphore class >> #new. * kernel/URL.st: Remove URL class >> #new. * scripts/Remote.st: Remove RemoteServer class >> #new. * tests/intmath.st: Remove PiSeries class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Announcements.st: Remove Announcer class >> #new, SubscriptionRegistry class >> #new. * AnnouncementsTests.st: Remove TestSubscriber class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * PText.st: Remove PWorksheetText class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * BloxText.st: Remove BTextBindings class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * CairoPattern.st: Remove GradientPattern class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Amb.st: Remove Amb class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * debugtests.st: Use basicNew instead of the modified new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * md5.st: Remove MD5 class >> #new. * sha1.st: Remove SHA1 class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Glorp.st: Remove CachePolicy class >> #new, GlorpExpression class >> #new, ObjectTransaction class >> #new, Mapping class >> #new, DatabaseConverter class >> #new, DatabaseTable class >> #new, ElementBuilder class >> #new, GlorpSession class >> #new, TableSorter class >> #new, Tracing class >> #new, RowMap class >> #new, DatabaseType class >> #new, DatabaseRow class >> #new, Query class >> #new, Descriptor class >> #new, Join class >> #new, MultiRowMapKey class >> #new, DescriptorSystem class >> #new, DatabaseAccessor class >> #new, FieldValueWrapper class >> #new, CacheManager class >> #new, UnitOfWork class >> #new, Proxy class >> #new, DatabaseCommand class >> #new, DatabaseSequence class >> #new, Cache class >> #new, GlorpPreparedStatement class >> #new. * GlorpTest.st: Remove GlorpWorker class >> #new, GlorpBankAccount class >> #new, GlorpBankTransaction class >> #new, GlorpThingWithLotsOfDifferentCollections class >> #new, GlorpEncylopedia class >> #new, GlorpCustomer class >> #new, GlorpReservation class >> #new, GlorpInt4Test class >> #new, GlorpBankExampleSystem class >> #new, GlorpServiceCharge class >> #new, GlorpWeakCacheTest class >> #new, GlorTransformedTime class >> #new, GlorpMockSession class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Base.st: Remove GPObject class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * FileServer.st: Remove FileWebServer class >> #new. * WebServer.st: Remove WebRequest class >> #new. * WikiServer.st: Remove WikiPage class >> #new, WikiSettings class >> #new, Wiki class >> #new, WikiHTML class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * magritte-gst.st: Remove MAVisitor class >> #new, MAVisitor >> #initialize. * magritte-model.st: Remove MAAdaptiveModel class >> #new, MADescriptionBuilder class >> #new, MAFileModel class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * magritte-gst.st: Remove MAVisitor class >> #new, MAVisitor >> #initialize. * magritte-model.st: Remove MAAdaptiveModel class >> #new, MADescriptionBuilder class >> #new, MAFileModel class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Core/SDAbstractStore.st: Remove SDAbstractCore class >> #new, SDAbstractStore >> #initialize. * Core/SDActiveRecord.st: Remove SDActiveRecord class >> #new. * Core/SDConcurrentDictionary.st: Remove SDConcurrentDictionary class >> #new. * Store/SDMemoryStore.st: Remove SDMemoryStore class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * libsdl/EventSource.st: Remmove SdlEventSource class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Seaside-Core.st: Remove WABrush class >> #new, WAConfiguration class >> #new, WAHtmlBuilder class >> #new, WAHtmlDocument class >> #new, WALRUCache class >> #new, WAPresenter class >> #new, WAProcessMonitor class >> #new, WARenderingContext class >> #new, WAReportColumn class >> #new, WARequestHandler class >> #new, WAResponse class >> #new, WARoot class >> #new, WAUrl class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * magritte-seaside.st: Remove MAColumn class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Tests.st: Remove DummyStream class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * ParseTreeSearcher.st: Remove RBReadBeforeWrittenTester class >> #new, RBParseTreeRule class >> #new, RBParseTreeRule >> #initialize. * RBParseNodes.st: Remove RBProgramNodeVisitor class >> #new, RBProgramNodeVisitor >> #initialize. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Parser/SourceEval.st: Remove SourceEval class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * SUnit.st: Remove TestResource class >> #new, TestResult class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Core.st: Remove SwazooResource class >> #new. * HTTP.st: Remove AbstractHTTPServer class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * Tetris/TetrisField.st: Remove TetrisField class >> #new. 2014-07-26 Holger Hans Peter Freyther <[email protected]> * builder/NodeBuilder.st: Remove XMLNodeBuilder class >> #new. * dom/DOM.st: Remove Node class >> #new, DocuemntType class >> #new. * expat/ExpatPullParser.st: Remove SAXEventSequence class >> #new. * parser/XML.st: Remove Pattern class >> #new. * pullparser/XMLPullParser.st: Remove XMLPullParser class >> #new. * saxdriver/SAX.st: Remove SAXDispatcher class >> #new. * saxparser/Parser.st: Remove SAXParser class >> #new. * xpath/XPath.st: Remove XPathNodeContext class >> #new, XPathExpression class >> #new. * xsl/XSL.st: Remove RuleDatabase class >> #new.
The splitting failed as the code called "nil size" which was not inside the valid indexes of the array. Use the keyValue variable and add a testcase. Fixes: #863 2014-08-16 Holger Hans Peter Freyther <[email protected]> * kernel/URL.st: Use keyValue instead of value. 2014-08-16 Holger Hans Peter Freyther <[email protected]> * kernel/URLTest.st: Add test for URL>>#decodedFields.
The addition of calling both basicNew/basicNew: followed by a call to initialize introduced a noticable slowdown in an allocation macro benchmark. By making the new >>new/>>new: a primitive we reduce the cost. The #initialize symbol is part of the builtin selectors so we can not blindly allocate it during the construction of the symbol table but will take the result of the built-in selectors. 2014-08-02 Holger Hans Peter Freyther <[email protected]> * prims.def: Introduce VMpr_Behavior_newInitialize and VMpr_Behavior_newColonInitialize, * sym.h: Declare _gst_initialize_symbol. * sym.c: Define _gst_initialize_symbol during init and restore. 2014-08-02 Holger Hans Peter Freyther <[email protected]> * kernel/Builtins.st: Use the new built-in for >>#new and >>#new:.
The code path to work with integer as second argument has been broken forever. Let's just remove it. It should have used '&' instead of '&&' to apply the bitmask. 2014-09-13 Holger Hans Peter Freyther <[email protected]> * prims.def: Remove opening with second argument as integer.
The below Smalltalk code could trigger a race condition. We would program a timer and then program another one before the first has expired. If the original timer expires after we have set signal handler but before the syscall to set the new timer was called. We could receive SIGALARM and our signal handler would set SIG_DFL as the handler for SIGALARM. When the new expiration is set and expires the default handler will terminate the process. Setting the application to SIG_IGN the handled signal could lead to a deadlock as the real expiration is never signalled to the Smalltalk side. The best approach seems to cancel the timer. Before we have canceled the timer we might run through the signal handler and signal the original sempahore but that appears to be fine as we will not miss an event or revert the signal handler too early. It might be best to combine "TimeoutSem initialize" of Delay class>>#handleDelayRequstor with the cancelation of the timer. I have only verified the working of the posix timer (timer_settime) and not the old interface. Eval [ | sem a | sem := Semaphore new. a := [ [ (Delay forMilliseconds: 250) wait. sem signal. ] repeat. ] fork. b := [ [ (Delay forMilliseconds: 125) timedWaitOn: sem. ] repeat. ] fork. c := [ [ (Delay forMilliseconds: 125) timedWaitOn: sem. ] repeat. ] fork. stdin next. ] 2014-09-26 Holger Hans Peter Freyther <[email protected]> * sysdep.h: Declare _gst_sigalrm_cancel. * sysdep/posix/events.c: Call _gst_sigalrm_cancel. * sysdep/posix/timer.c: Implement _gst_sigalrm_cancel.
These values were not documented. Specially using an already existing image file is a common usecase. 2015-01-25 Holger Hans Peter Freyther <[email protected]> * scripts/Remote.st: Document -I and --no-line-numbers.
When working on the JIT and disabling inlining of integers we have bootstrap issues as FloatD>>signByte is using a compile time constant that requires the usage of SmallInteger. (ip 8)SmallInteger(Object)>>#subclassResponsibility (ip 4)SmallInteger(Magnitude)>>#< (ip 6)SmallInteger(Magnitude)>>#>= (ip 18)UndefinedObject(FloatD class)>>#executeStatements (ip 0)<bottom> nil kernel/FloatD.st:56: Aborted 2015-02-03 Holger Hans Peter Freyther <[email protected]> * files.c: Include SmallInt.st before Float.st.
create_timer is not available on OSX which means the code will fall back to use setitimer. In case we want to sleep a short amount of time we either cancel the timeout or sleep a very long time. * If nsTime < now we would sleep a very long time. * If deltaMilli == 0 we could cancel the timer and never wake up. If the delta is smaller than what can be expressed in milliseconds sleep the shortest time possible as it is too late to cancel everything. This could be easily reproduced using the following code which would be unlikely to run to the end. (Delay forMilliseconds: 1) wait (Delay forMilliseconds: 1) wait (Delay forMilliseconds: 1) wait (Delay forMilliseconds: 1) wait (Delay forMilliseconds: 1) wait (Delay forMilliseconds: 1) wait (Delay forMilliseconds: 1) wait (Delay forMilliseconds: 1) wait
The code attempted to go through the columns and then collect their name, instead it collected the name of the table for each column. DBI doesn't have unit tests by itself so I am using the SQLite implementation to run the test. 2015-08-01 Holger Hans Peter Freyther <[email protected]> * Table.st: Fix >>#columnNames to return the column names and not the table name. 2015-08-01 Holger Hans Peter Freyther <[email protected]> * SQLiteTests.st: Add SQLiteTableTestCase class and >>#testTableColumns. Add the testTableColumns to the SQLiteTestSuite class >> #suite selector.
fdatasync appears to be available when linking but there is no declaration in XNU. Move from checking the function to checking the declaration. Fixes: cint.c:663:35: error: use of undeclared identifier 'fdatasync' _gst_define_cfunc ("fdatasync", fdatasync); ^ 2015-05-21 Holger Hans Peter Freyther <[email protected]> * configure.ac: Move from AC_CHECK_FUNCS_ONCE to AC_CHECK_DECLS for fdatasync. 2015-05-21 Holger Hans Peter Freyther <[email protected]> * cint.c: Change to use #if instead of #ifdef and update the macro to change for.
Use if () {} else {} instead of an else if() {} that would always be true. First we compare cur_time to < next_poll_ms so in the else branch it must be >=. events.c:218:20: warning: variable 'ms' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (cur_time >= next_poll_ms) ^~~~~~~~~~~~~~~~~~~~~~~~ events.c:233:11: note: uninitialized use occurs here if (ms == INFINITE) ^~ events.c:218:16: note: remove the 'if' if its condition is always true else if (cur_time >= next_poll_ms) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ events.c:207:18: note: initialize the variable 'ms' to silence this warning unsigned ms; ^ = 0 2015-08-02 Holger Hans Peter Freyther <[email protected]> * events.c: Use else instead of else if in poll_timer_thread.
File does not understand first. Follow the comment and reject any file that starts with '.' by first stripping the path and converting it to a String. Manually tested using interactive GST session on '/Users/ich'. The issue was reported by Mark Bratcher on github. 2015-08-08 Holger Hans Peter Freyther <[email protected]> * Seaside-GST.st: Correct >>#filesIn:.
In ac2ada5 I had changed >>#new to always call >>#initialize. When converting the code I did not update the MySQLPacket class that assumes that a stream has been set before initialize is being called. Use >>#basicNew to avoid the early call to >>#initialize. This has been found and analyzed by Mark Bratcher. 2015-09-08 Holger Hans Peter Freyther <[email protected]> * Connection.st: Use >>#basicNew in MySQLPacket class >> #on:.
The printing of Integers didn't work as the stream was attempted to be indexed out of bounds and the calculation of the number of required groups was wrong in many cases. 2015-10-18 Holger Hans Peter Freyther <[email protected]> * package.xml: Add LcNumericTest.st and testcase. * Number.st: Fix calculation in >>#computeNumberOfGroups. Support integer printing in >>#basicPrint:on:. * LcNumericTest.st: Add new testcase.
2015-11-07 Holger Hans Peter Freyther <[email protected]> * configure.ac: Increase the version number after the release.
Apple clang on OSX and the version on FreeBSD optimize the multiplication check away. Clang introduced a family of builtins to do the multiplication and check for the overflow and GCC made the API usable. For clang we would need to know if intptr_t is of type int, long int, long long int and then use the smul, smull smulll. Luckily clang is adopting the better interface and this is what we are starting to use now. This means the new code will be used on GCC5 (and later) and some future versions of clang. 2015-11-07 Holger Hans Peter Freyther <[email protected]> * build-aux/overflow-builtins.m4: Add new macro. * configure.ac: Use GST_C_OVERFLOW_BUILTINS macro. 2015-11-07 Holger Hans Peter Freyther <[email protected]> * interp.inl: Add alternative mul_with_check implementation.
The code assumes that parentView is set before >>#initialize is called and this assumption was broken by the change. In the long run it might be best to call this routine >>#initializeView and or integrate the setting of the parent view. The patch changes the base class to restore the old behavior for creation. Call >>#initialize on the Workspace so that the variableNames tracker is properly initialized. Remove one unneeded call for the STInST module. 2016-01-23 Holger Hans Peter Freyther <[email protected]> * BrowShell.st: Call >>#initialize. * DebugSupport.st: Do not call >>#initialize. * View.st: Use >>#basicNew to instantiate. 2016-01-23 Holger Hans Peter Freyther <[email protected]> * BloxBasic.st: Use >>#basicNew to create Gui items.
2016-01-25 Thomas Weir Worthington <[email protected]> * ClassHierBrow.st: updated method template to new syntax [hfreyther: Manually applied the patch]
With flex 2.6.0 the minor version is < 31 and one would end with redefining the yylineno. Make the check more specific. 2016-09-18 Holger Hans Peter Freyther <[email protected]> * genbc-scan.l: Compile with flex 2.6.0. * genpr-scan.l: Compile with flex 2.6.0. * genvm-scan.l: Compile with flex 2.6.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge with current upstream master from http://git.savannah.gnu.org/r/smalltalk.git
it appears that most of the branches on this fork are stale - these are the current upstream branches
there are also the following tags which would need to be pushed manually