Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

필요 없는 파일 제거 및 CI 구성 #121

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

Tolerblanc
Copy link
Member

🔖 연관된 이슈

Closes #115

📂 작업 내용

  • FE/BE .gitignore 통합하여 루트에 위치
  • 사용하지 않는 더미 파일 제거
  • 기본 CI 파이프라인 액션 작성
    • FE lint 실행
    • FE build 테스트
    • BE lint 실행
    • BE build 테스트
    • BE 단위 테스트 실행
  • PR 관련 자동화 액션 작성
    • PR 작성자를 자동으로 Assignee에 지정
    • FE/BE 라벨에 따라 Reviewer 자동 지정
    • Approve 상태일 경우, 자동으로 머지하고 브랜치 삭제

📢 리뷰 요구사항 (선택)

  • 스크립트 보고 이상한 점 발견해주시면 감사하겠습니다...!
  • 또는, 추가되면 좋을 법한 기능 제안도 좋습니다

- 자동 assignee 지정
- 자동 reviewer 지정
- approve 상태일 경우 자동으로 머지하며 브랜치 삭제
@Tolerblanc Tolerblanc added 🐰🐣 FE 프론트엔드 관련 이슈/PR 추적 라벨 🐧🚀😶‍🌫️ BE 백엔드 관련 이슈/PR 추적 라벨 ♻️ Refactor 기능 추가 외 코드 변경, 코드 품질과 관련된 경우 labels Nov 12, 2024
@Tolerblanc Tolerblanc self-assigned this Nov 12, 2024
@Tolerblanc Tolerblanc linked an issue Nov 12, 2024 that may be closed by this pull request
3 tasks
@Tolerblanc
Copy link
Member Author

GPT가 엿을 먹이다니

@Tolerblanc Tolerblanc changed the title Feature shared #115 필요 없는 파일 제거 및 CI 구성 Nov 12, 2024
@Tolerblanc
Copy link
Member Author

BE 린트 에러 @ezcolin2 @summersummerwhy

Run yarn lint
yarn run v1.22.22
$ eslint "{src,apps,libs,test}/**/*.ts" --fix

/home/runner/work/web1[5](https://github.com/boostcampwm-2024/web15-OctoDocs/actions/runs/11798220338/job/32864049098?pr=121#step:5:6)-OctoDocs/web15-OctoDocs/backend/src/page/dtos/findPageResponse.dto.ts
Error:   2:20  error  'IsArray' is defined but never used  @typescript-eslint/no-unused-vars

/home/runner/work/web15-OctoDocs/web15-OctoDocs/backend/src/page/page.controller.ts
Error:   12:[10](https://github.com/boostcampwm-2024/web15-OctoDocs/actions/runs/11798220338/job/32864049098?pr=121#step:5:11)  error  'Page' is defined but never used  @typescript-eslint/no-unused-vars

✖ 2 problems (2 errors, 0 warnings)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

@Tolerblanc
Copy link
Member Author

FE 린트에러 @djk01281 @yewonJin

Run yarn lint
yarn run v1.22.22
$ eslint .

/home/runner/work/web15-OctoDocs/web15-OctoDocs/frontend/src/components/editor/index.tsx
Error:   1:10  error  'useEffect' is defined but never used  @typescript-eslint/no-unused-vars

/home/runner/work/web15-OctoDocs/web15-OctoDocs/frontend/src/components/editor/selectors/link-selector.tsx
Warning:   10:17  warning  Fast refresh only works when a file only exports components. Use a new file to share constants or functions between components  react-refresh/only-export-components
Warning:   18:17  warning  Fast refresh only works when a file only exports components. Use a new file to share constants or functions between components  react-refresh/only-export-components

/home/runner/work/web15-OctoDocs/web15-OctoDocs/frontend/src/components/editor/ui/button.tsx
Warning:   [4](https://github.com/boostcampwm-2024/web15-OctoDocs/actions/runs/11798220338/job/32864056996?pr=121#step:5:5)7:18  warning  Fast refresh only works when a file only exports components. Use a new file to share constants or functions between components  react-refresh/only-export-components

/home/runner/work/web1[5](https://github.com/boostcampwm-2024/web15-OctoDocs/actions/runs/11798220338/job/32864056996?pr=121#step:5:6)-OctoDocs/web15-OctoDocs/frontend/src/components/editor/ui/command.tsx
Error:   2[6](https://github.com/boostcampwm-2024/web15-OctoDocs/actions/runs/11798220338/job/32864056996?pr=121#step:5:7):11  error  An interface declaring no members is equivalent to its supertype  @typescript-eslint/no-empty-object-type

✖ 5 problems (2 errors, 3 warnings)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

FE 빌드 에러

Run yarn build
yarn run v1.22.22
$ tsc -b && vite build
Error: src/components/EditorView.tsx(1[4](https://github.com/boostcampwm-2024/web15-OctoDocs/actions/runs/11798220338/job/32864057426?pr=121#step:5:5),6): error TS2739: Type '{ key: number; initialContent: JSONContent; pageId: number; }' is missing the following properties from type 'EditorProp': ydoc, provider
Error: src/components/editor/index.tsx(1,10): error TS[6](https://github.com/boostcampwm-2024/web15-OctoDocs/actions/runs/11798220338/job/32864057426?pr=121#step:5:7)133: 'useEffect' is declared but its value is never read.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 2.

Copy link
Collaborator

@djk01281 djk01281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 👏🏻👏🏻 너무 좋네요!!

@github-actions github-actions bot requested a review from djk01281 November 12, 2024 15:12
@github-actions github-actions bot merged commit 4d3938b into develop Nov 12, 2024
9 of 10 checks passed
@github-actions github-actions bot deleted the feature-shared-#115 branch November 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐧🚀😶‍🌫️ BE 백엔드 관련 이슈/PR 추적 라벨 🐰🐣 FE 프론트엔드 관련 이슈/PR 추적 라벨 ♻️ Refactor 기능 추가 외 코드 변경, 코드 품질과 관련된 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

필요없는 파일 정리 & CI 파이프라인 구성
2 participants