-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monorepo로 변경 #174
Merged
Merged
monorepo로 변경 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Tolerblanc
requested changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
성민님 고생하셨습니다!! 몇 가지 필요없는 파일이 포함된 것 같아서 Request changes 달아두었습니다.
apps/frontend/vite.config.ts.timestamp-1731683160030-f87f81a9de1db.mjs
Outdated
Show resolved
Hide resolved
ezcolin2
force-pushed
the
be-feature-#173
branch
from
November 16, 2024 11:25
04320d8
to
318fbe6
Compare
추가로 CI workflow도 turbo를 통해 프론트, 백엔드 동시에 진행하도록 변경했습니다! |
Tolerblanc
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔖 연관된 이슈
📂 작업 내용
📢 리뷰 요구사항 (선택)
현재 .env 파일을 apps/backend와 apps/frontend 모두 붙여넣어야 합니다.
원래 루트 디렉토리에서 한 번에 가져오도록 하려고 했는데 프론트엔드 환경 변수 위치 설정을 하는 법을 몰라서 일단 그대로 두었습니다.
프론트엔드 분들 import.meta.env로 가져올 때 환경 변수 위치 바꾸는 방법 알려주시면 감사하겠습니다!
그리고 api 호출하실 때 /api 앞에 붙이셔야 합니다!
현재 코드들은 제가 /api 붙여서 수정해두었습니다.
로컬에서 테스트 할 때
루트 디렉토리에서 yarn run dev 실행한 뒤 localhost:5173으로 접속하시면 자동으로 local에 띄워둔 서버로 연결이 됩니다.
상용에서 띄울 때
yarn run build를 통해 빌드 한 뒤 yarn run start를 사용하면 됩니다.